Skip to content

Remove FileHandle deprecated APIs #12549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2020
Merged

Remove FileHandle deprecated APIs #12549

merged 1 commit into from
Mar 4, 2020

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Mar 2, 2020 •
edited
Loading

Summary of changes

Removed FileHandle deprecated APIs.

Impact of changes

Breaking change: FileHandle lseek, fsync, and flen methods have been deprecated since Mbed OS 5.4 and they are removed now.

Migration actions required

Use FileHandle seek(), sync(), and size() methods.

Documentation

None

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[x] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon

@ciarmcom ciarmcom requested a review from evedon March 2, 2020 16:00
@ciarmcom
Copy link
Member

ciarmcom commented Mar 2, 2020

@rajkan01, thank you for your changes.
@evedon @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from a team March 2, 2020 16:00
@rajkan01 rajkan01 changed the title Remove the deprecated FileHandle APIs Remove FileHandle deprecated APIs Mar 2, 2020
@mergify mergify bot added needs: CI and removed needs: review labels Mar 2, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 3, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 3, 2020

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 40fb45e into ARMmbed:master Mar 4, 2020
@mergify mergify bot removed the ready for merge label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@evedon evedon evedon approved these changes

Assignees

No one assigned

Labels

BREAKING-CHANGE release-version: 6.0.0-alpha-3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rajkan01 @ciarmcom @0xc0170 @mbed-ci @evedon