Skip to content

Cellular: Add offload TLSSocket implementation inside feature flag #12633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2020
Merged

Cellular: Add offload TLSSocket implementation inside feature flag #12633

merged 1 commit into from
Mar 17, 2020

Conversation

kivaisan
Copy link
Contributor

@kivaisan kivaisan commented Mar 16, 2020 •
edited
Loading

Summary of changes

Add BG96 implementation of offloaded TLSSocket inside MBED_CONF_NSAPI_OFFLOAD_TLSSOCKET flag

Impact of changes

Reduce binary size (~500 bytes with GCC_ARM and developer profile) when offloaded TLSSocket is not in use.

Migration actions required

None

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ARMmbed/mbed-os-wan

AnttiKauppila
AnttiKauppila previously approved these changes Mar 16, 2020
View reviewed changes
@mergify mergify bot added the needs: CI label Mar 16, 2020
Cellular: Add offload TLSSocket implementation inside feature flag
51175ee 
Reduce binary size (~500 bytes with GCC_ARM and developer profile) when offloaded TLSSocket is not in use.
@mergify mergify bot dismissed AnttiKauppila’s stale review March 17, 2020 06:43

Pull request has been modified.

@kivaisan
Copy link
Contributor Author

@AnttiKauppila Please rereview. I also added set_to_modem_impl -method inside TLSSocket flag.

@mbed-ci
Copy link

mbed-ci commented Mar 17, 2020

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit dc21432 into ARMmbed:master Mar 17, 2020
@mergify mergify bot removed the ready for merge label Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+1 more reviewer

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 6.0.0-beta-1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kivaisan @mbed-ci @0xc0170 @AnttiKauppila