Skip to content

Conversation

michalpasztamobica
Copy link
Contributor

@michalpasztamobica michalpasztamobica commented Mar 26, 2020

Summary of changes

Fixes #12503.
The error code is now propagated correctly out of netconn_apimsg(). So far ERR_OK was always returned. Compare to the original LWIP's code a few lines below, where the fn() return value isn't checked either, so clearly there must be an assumption that the function will set the error code appropriately. I think we should follow the LWIP's way.
See also the issue and the discussion in there for more details.

Impact of changes

Error code propagation improvement.

Migration actions required

None

Documentation

None


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@AnttiKauppila
@SeppoTakalo
@kjbracey-arm
@JojoS62


@ciarmcom ciarmcom requested review from a team, AnttiKauppila, SeppoTakalo and kjbracey March 26, 2020 12:00
@ciarmcom
Copy link
Member

@michalpasztamobica, thank you for your changes.
@AnttiKauppila @SeppoTakalo @kjbracey-arm @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Mar 26, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 26, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 27, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@mergify
Copy link

mergify bot commented Mar 27, 2020

This PR does not contain release version label after merging.

@mergify mergify bot added the release version missing When PR does not contain release version, bot should label it and we fix it afterwards label Mar 27, 2020
@0xc0170 0xc0170 removed the release version missing When PR does not contain release version, bot should label it and we fix it afterwards label Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LwIP bind() does not promote error to caller

7 participants