LWIP: propagate the apimsg->err out of netconn_apimsg() #12704
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes #12503.
The error code is now propagated correctly out of
netconn_apimsg()
. So far ERR_OK was always returned. Compare to the original LWIP's code a few lines below, where thefn()
return value isn't checked either, so clearly there must be an assumption that the function will set the error code appropriately. I think we should follow the LWIP's way.See also the issue and the discussion in there for more details.
Impact of changes
Error code propagation improvement.
Migration actions required
None
Documentation
None
Pull request type
Test results
Reviewers
@AnttiKauppila
@SeppoTakalo
@kjbracey-arm
@JojoS62