Update mbed-coap to version v5.1.5 for feature-wisun #12868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add also 4.13 (Request Entity Too Large) responses to duplicate info list. Add client library configurations for DEFAULT_RESPONSE_TIMEOUT and SN_COAP_DUPLICATION_MAX_TIME_MSGS_STORED. Increased the default timeouts of DEFAULT_RESPONSE_TIMEOUT and SN_COAP_DUPLICATION_MAX_TIME_MSGS_STORED to 300 seconds. These two are critical parameters for low-bandwidth high-latency networks. The defaults should be more geared towards such networks that are likely to have issues with transmissions. The increased defaults can increase the runtime HEAP usage when there is a lot of duplicates or retransmissions.
BLOCK2 code-branch was missing handling for duplicate packets. As part of the fix, added also a call to update the duplicate package data via a new function sn_coap_protocol_update_duplicate_package_data_all. The new implementation handles all CoAP messages, not just those with COAP_MSG_TYPE_ACKNOWLEDGEMENT.
teetak01
changed the title
Member
|
@teetak01, thank you for your changes. |
anttiylitokola
approved these changes
Apr 27, 2020
0xc0170
approved these changes
Apr 27, 2020
Contributor
|
@artokin We can start CI later today |
Contributor
|
CI started |
Test run: SUCCESSSummary: 10 of 10 test jobs passed |
yogpan01
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
BLOCK2 code-branch was missing handling for duplicate packets. As part of the fix, added also
a call to update the duplicate package data via a new function
sn_coap_protocol_update_duplicate_package_data_all.
The new implementation handles all CoAP messages, not just those with COAP_MSG_TYPE_ACKNOWLEDGEMENT.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers
@yogpan01 @anttiylitokola @artokin