-
Notifications
You must be signed in to change notification settings - Fork 3k
Modify the operation of setting qspi frequency when calling Octo controller #12937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f4e8fa8 to
90c1f89
Compare
|
@rogeryou, thank you for your changes. |
0xc0170
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you amend the commit - add there info why is this being modified, I dont understand the reasoning.
div is for setting the prescaler, If the div is 3, the value write to the controller register should be 2.
But for ST OSPI controller driver, before the value is set into the register , it will be subtracted 1, as the code below: ` So, "div = div - 1;" should be removed. |
|
Part of the information should be in the commit message. @ARMmbed/team-st-mcd Please review |
For ST OSPI controller driver(stm32l4xx_hal_ospi.c), the frequency it has be subtracted 1, so "div = div - 1;" should be removed.
Hi, |
|
|
@0xc0170 are you ok with this now ? |
|
CI started |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
Summary of changes
Modify the operation of setting qspi frequency when calling Octo controller in qspi_api.c.
Because the value of hospi->Init.ClockPrescaler has been subtracted 1 in stm32l4xx_hal_ospi.c.
Impact of changes
N/A
Migration actions required
N/A
Documentation
N/A
Pull request type
Test results
Reviewers