Skip to content

Cellular: Fix unittest for CellularNetwork #13069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2020
Merged

Cellular: Fix unittest for CellularNetwork #13069

merged 1 commit into from
Jun 10, 2020

Conversation

AriParkkila
Copy link

Summary of changes

Fix #13059.

Impact of changes

Migration actions required

Documentation

None.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@AriParkkila AriParkkila mentioned this pull request Jun 5, 2020
Closed
kivaisan
kivaisan suggested changes Jun 5, 2020
View reviewed changes
features/cellular/framework/AT/AT_CellularNetwork.cpp Outdated
int ret;
nsapi_error_t error = _at.at_cmd_int("+COPS", "?", ret);
mode = (NWRegisteringMode)ret;
if (!error) {
Copy link
Contributor

@kivaisan kivaisan Jun 5, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compare error to NSAPI_ERROR_OK

@AriParkkila AriParkkila force-pushed the fix-unittest-for-CellularNetwork branch from 499a50a to 985e72f Compare June 5, 2020 07:46
@ciarmcom ciarmcom requested review from a team June 5, 2020 09:00
@ciarmcom
Copy link
Member

ciarmcom commented Jun 5, 2020

@AriParkkila, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Jun 8, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 9, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 9, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jun 10, 2020
@0xc0170 0xc0170 merged commit 12910ea into ARMmbed:master Jun 10, 2020
@mergify mergify bot removed the ready for merge label Jun 10, 2020
@adbridge adbridge added release-version: 6.1.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+1 more reviewer

@kivaisan kivaisan kivaisan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 6.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Platform dependent enum type may cause problems

6 participants

@AriParkkila @ciarmcom @0xc0170 @mbed-ci @kivaisan @adbridge