add mbed-os-example-aws to the example list #13070

ithinuel · 2020-06-05T08:03:23Z

Summary of changes

This PR adds armmbed/mbed-os-example-aws to the CI build test list.

Impact of changes

None

Migration actions required

None

Documentation

None

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

ciarmcom · 2020-06-05T09:00:31Z

@ithinuel, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

MarceloSalazar · 2020-06-05T09:26:48Z

tools/test/examples/examples.json

+      "compile" : true,
+      "export": true,
+      "test" : false,
+      "baud_rate": 9600,


It should be 115200 bauds
See https://github.com/ARMmbed/mbed-os-example-aws/blob/master/mbed_app.json#L25

Good catch!

LDong-Arm · 2020-06-05T13:47:29Z

Blocked by ARMmbed/mbed-os-example-for-aws#3

0xc0170 · 2020-06-08T12:18:29Z

Blocked by ARMmbed/mbed-os-example-for-aws#3

To verify, I'll trigger now CI , should fail

mbed-ci · 2020-06-08T12:50:40Z

Test run: FAILED

Summary: 2 of 3 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM

0xc0170 · 2020-06-09T09:19:18Z

CI confirmed, blocked by ARMmbed/mbed-os-example-for-aws#3

LDong-Arm · 2020-06-16T16:03:27Z

CI confirmed, blocked by ARMmbed/mbed-os-example-aws#3

Fixed now, this PR should work. Could you trigger the CI again? @0xc0170

LDong-Arm

LGTM

0xc0170 · 2020-06-17T10:11:30Z

Looks like GCC ARM already failed, please review (logs will be published once arm also completes)

mbed-ci · 2020-06-17T10:12:49Z

Test run: FAILED

Summary: 2 of 3 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-ARM

LDong-Arm · 2020-06-17T10:46:33Z

@0xc0170 Looks like we have duplicated copies of the wifi-ism43362 library.

During the Greentea stage, the CI script added that library into the mbed-os/ directory:

[2020-06-17T09:47:02.112Z] + python -m mbed add wifi-ism43362
[Pipeline] // dir
[Pipeline] // dir
[Pipeline] // dir
[Pipeline] sh
[2020-06-17T09:47:02.378Z] + export DAPLINK_TIMESTAMP=0
[2020-06-17T09:47:02.378Z] + echo 
[2020-06-17T09:47:02.378Z] + echo python -m mbed test --compile -j 8 -m NUCLEO_F429ZI -t GCC_ARM --build-data BUILD/tests/build_data.json -DMBED_TRAP_ERRORS_ENABLED=1 -DSKIP_TIME_DRIFT_TESTS=1

But it doesn't seem to clean it up afterwards.

When it came to testing our AWS example, the example fetched wifi-ism43362 into its own directory and we ended up with two copies.

LDong-Arm · 2020-06-17T10:51:21Z

In fact, mbed-os-example-wifi relies on the wifi-ism43362 added by the CI script. (In a non-CI setup, the README tells the user to manually import it.)

If we add a step to clean it up, I suppose the AWS example will work but the WiFi example will not compile in CI anymore... We need to align them I guess.

0xc0170 · 2020-06-17T12:39:58Z

@LDong-Arm please talk to @jamesbeyond how to address this wifi copy/clean up issue

LDong-Arm · 2020-06-17T17:00:46Z

tools/test/examples/examples.json

+      "sub-repo-example": false,
+      "subs": [],
+      "features" : [],
+      "targets" : [],


Should we limit the targets? For example, the previous CI run also tried to build for NUCLEO_F411RE and failed, ~~and I don't think it's a WiFi or Ethernet target~~.

It's due to the lack of TRNG on this target, see ARMmbed/mbed-os-example-tls-socket#34

For the WiFi example (line 120) we only build it for one target.

Maybe K64F (Ethernet), and one WiFi target TBC

We should limit to a few targets with supported HW. @jamesbeyond

Do we have a blocker created for this ? To my understanding this should be in 6.1 correct?

This needs to go in 6.1.

Okay if we set targets in the future, since the example is disabled for now...

0xc0170 · 2020-06-22T11:00:01Z

This needs to go in 6.1.

@LDong-Arm Please let us know how to proceed here. I've reviewed the dependencies and it's not clear to me (providing the status here would help). If we can resolve this by end of today it would be great.

evedon · 2020-06-22T12:34:50Z

This needs to go in 6.1.

@LDong-Arm Please let us know how to proceed here. I've reviewed the dependencies and it's not clear to me (providing the status here would help). If we can resolve this by end of today it would be great.

We agreed to set "targets" to DISCO_L475VG_IOT01A and K64F and "compile" to false pending updates to CI that will be done post 6.1.

Pull request has been modified.

0xc0170 · 2020-06-22T13:19:11Z

CI started

LDong-Arm · 2020-06-22T13:29:03Z

tools/test/examples/examples.json

+      "sub-repo-example": false,
+      "subs": [],
+      "features" : [],
+      "targets" : [],


Okay if we set targets in the future, since the example is disabled for now...

mbed-ci · 2020-06-22T14:02:44Z

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 3
Build artifacts

ciarmcom requested review from a team June 5, 2020 09:00

ciarmcom added the needs: review label Jun 5, 2020

MarceloSalazar reviewed Jun 5, 2020

View reviewed changes

evedon requested a review from jamesbeyond June 5, 2020 10:07

add mbed-os-example-aws to the test build list

dbf206c

0xc0170 added needs: CI and removed needs: review labels Jun 8, 2020

mergify bot added needs: work and removed needs: CI labels Jun 8, 2020

adbridge added the release-type: patch Indentifies a PR as containing just a patch label Jun 11, 2020

LDong-Arm approved these changes Jun 16, 2020

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels Jun 17, 2020

mergify bot added needs: work and removed needs: CI labels Jun 17, 2020

LDong-Arm reviewed Jun 17, 2020

View reviewed changes

0xc0170 added the priority: high label Jun 22, 2020

0xc0170 mentioned this pull request Jun 22, 2020

Update the list of supported WiFi modules ARMmbed/mbed-os-example-wifi#195

Merged

0xc0170 previously approved these changes Jun 22, 2020

View reviewed changes

disable compilation in CI

d4e9267

ithinuel changed the title ~~add mbed-os-example-aws to the test build list~~ add mbed-os-example-aws to the example list Jun 22, 2020

0xc0170 approved these changes Jun 22, 2020

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels Jun 22, 2020

LDong-Arm approved these changes Jun 22, 2020

View reviewed changes

mergify bot added ready for merge and removed needs: CI labels Jun 22, 2020

0xc0170 merged commit 107d9bb into ARMmbed:master Jun 22, 2020

mergify bot removed the ready for merge label Jun 22, 2020

LDong-Arm mentioned this pull request Jun 22, 2020

Re-enable AWS example, limit targets #13171

Merged

adbridge added release-version: 6.1.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 24, 2020

add mbed-os-example-aws to the example list #13070

add mbed-os-example-aws to the example list #13070

Uh oh!

Conversation

ithinuel commented Jun 5, 2020

Summary of changes

Impact of changes

Migration actions required

Documentation

None

Pull request type

Test results

Reviewers

Uh oh!

ciarmcom commented Jun 5, 2020

Uh oh!

MarceloSalazar Jun 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LDong-Arm commented Jun 5, 2020

Uh oh!

0xc0170 commented Jun 8, 2020

Uh oh!

mbed-ci commented Jun 8, 2020

Uh oh!

0xc0170 commented Jun 9, 2020

Uh oh!

LDong-Arm commented Jun 16, 2020

Uh oh!

LDong-Arm left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Jun 17, 2020

Uh oh!

mbed-ci commented Jun 17, 2020

Uh oh!

LDong-Arm commented Jun 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LDong-Arm commented Jun 17, 2020

Uh oh!

0xc0170 commented Jun 17, 2020

Uh oh!

LDong-Arm Jun 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Jun 22, 2020

Uh oh!

evedon commented Jun 22, 2020

Uh oh!

0xc0170 commented Jun 22, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mbed-ci commented Jun 22, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

MarceloSalazar Jun 5, 2020 •

edited

Loading

LDong-Arm commented Jun 17, 2020 •

edited

Loading

LDong-Arm Jun 17, 2020 •

edited

Loading