Skip to content

Conversation

@vmedcy
Copy link
Contributor

@vmedcy vmedcy commented Jun 11, 2020

Summary of changes

PSoC 64 secure BSP post-build hook (cysecuretools image signing)
expects the HEX file with start address 0x10000400 (first KB of
internal FLASH is reserved for MCUboot headers area).
In order to get the correct HEX file produced by ARM fromELF tool,
the ELF file should allocate LR_IROM1 starting from address
0x10000400, not 0x10000000. Otherwise the generated HEX file
allocates rows at addresses 0x10000000 ~ 010000400 and the
final application image is not signed correctly.

Fixes #13058.

Impact of changes

Fix TARGET_CY8CPROTO_064_SB and TARGET_CYESKIT_064B0S2_4343W signed HEX image generation with TOOLCHAIN=ARM.

Migration actions required

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


PSoC 64 secure BSP post-build hook (cysecuretools image signing)
expects the HEX file with start address 0x10000400 (first KB of
internal FLASH is reserved for MCUboot headers area).
In order to get the correct HEX file produced by ARM fromELF tool,
the ELF file should allocate LR_IROM1 starting from address
0x10000400, not 0x10000000. Otherwise the generated HEX file
allocates rows at addresses 0x10000000 ~ 010000400 and the
final application image is not signed correctly.

Fixes #13058.
@ciarmcom
Copy link
Member

@vmedcy, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

@adbridge
Copy link
Contributor

@vmedcy I've fixed the header for you. Description text should go in the Summary section.

@adbridge adbridge added release-type: patch Indentifies a PR as containing just a patch needs: review and removed needs: work labels Jun 11, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 15, 2020

I dont see why events would fail in Travis, restarted the job. Will schedule CI

@mergify mergify bot added needs: CI and removed needs: review labels Jun 15, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 15, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 15, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

Copy link
Contributor

@maclobdell maclobdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@0xc0170 0xc0170 merged commit e901ea9 into ARMmbed:master Jun 16, 2020
@mergify mergify bot removed the ready for merge label Jun 16, 2020
@adbridge adbridge added release-version: 6.1.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CYESKIT_064B0S2_4343W Test Fails w/ Arm Compiler

6 participants