Skip to content

travis: Reject changes to tools #13349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 11, 2020
Merged

travis: Reject changes to tools #13349

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc146cd
travis: Remove trailing whitespace
Patater Jul 24, 2020
5ea5159
travis: Fix spelling errors
Patater Jul 24, 2020
a18a739
travis: Reject changes to tools
Patater Jul 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 32 additions & 4 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ after_failure:

matrix:
include:

### Basic Tests ###
- &basic-vm
stage: "Basic"
Expand Down Expand Up @@ -127,7 +127,7 @@ matrix:
| ( grep -v -f .astyleignore || true ) \
| while read file; do astyle -n --options=.astylerc "${file}"; done
- git diff --exit-code --diff-filter=d --color

- <<: *docs-vm
name: "spellcheck"
env: NAME=doxy-spellcheck
Expand Down Expand Up @@ -169,13 +169,41 @@ matrix:
find "(" -name "*.a" -or -name "*.ar" ")" -and -not -name "lib*" |
tee BUILD/badlibs |
sed -e "s/^/Bad library name found: /" && [ ! -s BUILD/badlibs ]
# Assert that all assebler files are named correctly
# Assert that all assembler files are named correctly
# The strange command below asserts that there are exactly 0 libraries
# that do end with .s
- >
find -name "*.s" | tee BUILD/badasm |
sed -e "s/^/Bad Assembler file name found: /" && [ ! -s BUILD/badasm ]

- <<: *docs-vm
name: "Frozen tools check"
env: NAME=frozen_tools_check
script:
# Reject any changes to tools that would require a re-release of the
# tools for the online compiler.
- >-
frozen_files=`\
git diff --name-only --diff-filter=d FETCH_HEAD..HEAD \
| egrep \
-e "^tools/build_api*" \
-e "^tools/config*" \
-e "^tools/export*" \
-e "^tools/notifier*" \
-e "^tools/paths*" \
-e "^tools/resources*" \
-e "^tools/targets*" \
-e "^tools/toolchains*" \
-e "^tools/utils*" \
-e "^$"`
if [ -z "$frozen_files" ]; then
echo "Success!";
else
echo -e "Failure: Frozen files were modified\n$frozen_files";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a documentation we could point to here if not including more detailed message? Once it errors, we should have a reference why we froze and what it means for the future (for other branches as well, this is for master, same will be applied to 5.15 branch?). Shall we consider a blog post, including message about new build tools?

There is at least one opened PR that will be affected.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tools changes to 5.15 can go ahead, but they may not have the desired effect. They'll affect the offline tooling only. Any new features added there which Mbed OS 5.15.x would depend on, or any bug fixes made there, wouldn't become available in the Online Compiler. The Mbed Online Compiler uses only the latest tools, from mbed-os master.

Yes, we should do a blog post. I'll write one. Then we can link to it from the CI failure message. Let's hold off merging this PR until we have that blog post up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blog post is live at https://os.mbed.com/blog/entry/Introducing-the-new-Mbed-Tools/

echo -e "Please see https://os.mbed.com/blog/entry/Introducing-the-new-Mbed-Tools/" \
"\nfor why we've frozen the legacy tools.";
false;
fi

### Python Tests ###
- &pytools-vm
Expand Down Expand Up @@ -224,7 +252,7 @@ matrix:
env: NAME=tools-py3.7
python: 3.7


### Extended Tests ###
- &extended-vm
stage: "Extended"
Expand Down