Skip to content

Conversation

avptin
Copy link
Contributor

@avptin avptin commented Jul 31, 2020

Summary of changes

Update Cypress targets to the PSoC 6 PDL 1.6.1.

Updated Drivers

Impact of changes

Migration actions required

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ARMmbed/team-cypress


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 31, 2020
@ciarmcom ciarmcom requested review from a team and maclobdell July 31, 2020 17:00
@ciarmcom
Copy link
Member

@avptin, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed that a lot of these files do not have licenses attached. Please see our licensing docs
https://os.mbed.com/docs/mbed-os/v6.2/contributing/index.html#licensing and update accordingly

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 10, 2020

I've noticed that a lot of these files do not have licenses attached. Please see our licensing docs

@adbridge please can you share which files? I opened couple of them in drivers folder, they have the license headers.

@vmedcy
Copy link
Contributor

vmedcy commented Aug 10, 2020

Hello!

git fetch github pull/13386/head:psoc6pdl-1.6.1
git checkout psoc6pdl-1.6.1
cd targets/TARGET_Cypress/TARGET_PSOC6/psoc6pdl
grep -RL SPDX --exclude-dir udd --exclude "*.jar" .
./drivers/include/cy_crypto_core_ecc_nist_p.h
./LICENSE
./devicesupport.xml
./personalities/.cymigration
./personalities/version.xml
./README.md
./personalities_2.0/.cymigration
./personalities_2.0/version.xml
./RELEASE.md
./version.xml

I already fixed cy_crypto_core_ecc_nist_p.h in the internal development version of psoc6pdl, the fix will appear in Mbed OS tree after the next PDL release.

Regarding the other files - those are not FW sources but XML data files used internally by the tools (ModusToolbox configurators). I don't see a good reason to update non-C/C++ files with license identifiers. Everything is covered by Apache-2.0 as described in the top-level LICENSE file.

https://os.mbed.com/docs/mbed-os/v6.2/contributing/index.html#licensing recommends "Additionally, all source files must contain the SPDX identifier.". Stuff in udd and personalities directories is not source files.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 10, 2020

Thanks @vmedcy , looks fine to me

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 12, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 12, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 16, 2020

The issue #13440 referenced this PR as it broke one of the targets, please review

@mbedmain mbedmain added release-version: 6.2.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch labels Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants