-
Notifications
You must be signed in to change notification settings - Fork 3k
PSoC6: update to psoc6pdl-1.6.1 #13386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@avptin, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed that a lot of these files do not have licenses attached. Please see our licensing docs
https://os.mbed.com/docs/mbed-os/v6.2/contributing/index.html#licensing and update accordingly
@adbridge please can you share which files? I opened couple of them in drivers folder, they have the license headers. |
Hello!
I already fixed cy_crypto_core_ecc_nist_p.h in the internal development version of psoc6pdl, the fix will appear in Mbed OS tree after the next PDL release. Regarding the other files - those are not FW sources but XML data files used internally by the tools (ModusToolbox configurators). I don't see a good reason to update non-C/C++ files with license identifiers. Everything is covered by Apache-2.0 as described in the top-level LICENSE file. https://os.mbed.com/docs/mbed-os/v6.2/contributing/index.html#licensing recommends "Additionally, all source files must contain the SPDX identifier.". Stuff in udd and personalities directories is not source files. |
Thanks @vmedcy , looks fine to me |
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
The issue #13440 referenced this PR as it broke one of the targets, please review |
Summary of changes
Update Cypress targets to the PSoC 6 PDL 1.6.1.
Updated Drivers
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers
@ARMmbed/team-cypress