Skip to content

NRF52840_DK: Fix failure if MBED_BOOT_STACK_SIZE is not provided #13455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

NRF52840_DK: Fix failure if MBED_BOOT_STACK_SIZE is not provided #13455

wants to merge 1 commit into from

Conversation

@hugueskamba
Copy link
Collaborator

@hugueskamba hugueskamba commented Aug 18, 2020 •
edited
Loading

The same default value is provided in the GCC_ARM linker file.

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

  • Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
  • Feature update (New feature / Functionality change / New API)
  • Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

  • No Tests required for this change (E.g docs only update)
  • Covered by existing mbed-os tests (Greentea or Unittest)
  • Tests / results supplied as part of this PR

Reviewers

@hugueskamba hugueskamba requested a review from 0xc0170 August 18, 2020 12:30
@hugueskamba hugueskamba mentioned this pull request Aug 18, 2020
Merged
0xc0170
0xc0170 previously approved these changes Aug 18, 2020
View reviewed changes
@hugueskamba
NRF52840_DK: Fix failure if boot stack size is not provided
bb6be0b 
The same default value is provided in the GCC_ARM linker file.
@hugueskamba hugueskamba force-pushed the hk_nrf52840_default_boot_stack_size branch from 77a60d7 to bb6be0b Compare August 18, 2020 13:17
@mergify mergify bot dismissed 0xc0170’s stale review August 18, 2020 13:18

Pull request has been modified.

Patater
Patater approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@Patater Patater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot added the needs: CI label Aug 18, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 24, 2020

Ci started

@mergify mergify bot added needs: work and removed needs: CI labels Aug 24, 2020
@mbed-ci
Copy link

mbed-ci commented Aug 24, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_greentea-test ❌
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@Patater
Copy link
Contributor

Patater commented Aug 24, 2020

@0xc0170 I've included the commits from this PR in #13452

I believe we can close this one.

@mergify mergify bot removed the needs: work label Aug 24, 2020
@hugueskamba
Copy link
Collaborator Author

#13455 (comment)

@0xc0170 I've included the commits from this PR in #13452

I believe we can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 left review comments

+1 more reviewer

@Patater Patater Patater approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hugueskamba @0xc0170 @mbed-ci @Patater