Skip to content

CMake: Add support for printf lib selection #13615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2020
Merged

CMake: Add support for printf lib selection #13615

merged 1 commit into from
Sep 18, 2020

Conversation

@hugueskamba
Copy link
Collaborator

@hugueskamba hugueskamba commented Sep 15, 2020 •
edited
Loading

Summary of changes

Configure the selected toolchain for the selected printf library

Impact of changes

Minimal-printf will be the selected library as it is set as the default.

Migration actions required

Requires ARMmbed/mbed-tools#73 in mbed-tools

Documentation

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@hugueskamba hugueskamba requested a review from 0xc0170 September 15, 2020 12:43
0xc0170
0xc0170 previously approved these changes Sep 15, 2020
View reviewed changes
@mergify mergify bot added the needs: work label Sep 15, 2020
@hugueskamba hugueskamba force-pushed the hk_cmake_add_printf_lib_support branch from 9a71014 to 923ab5d Compare September 15, 2020 13:49
@mergify mergify bot dismissed 0xc0170’s stale review September 15, 2020 13:50

Pull request has been modified.

@hugueskamba
Copy link
Collaborator Author

This force-push validates the selected printf library.

@hugueskamba hugueskamba requested a review from 0xc0170 September 15, 2020 13:52
0xc0170
0xc0170 previously approved these changes Sep 15, 2020
View reviewed changes
@hugueskamba hugueskamba force-pushed the hk_cmake_add_printf_lib_support branch from 923ab5d to c5b69d6 Compare September 15, 2020 14:06
@hugueskamba hugueskamba requested a review from 0xc0170 September 15, 2020 14:06
@mergify mergify bot dismissed 0xc0170’s stale review September 15, 2020 14:07

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 16, 2020

Travis failed: mbed_set_printf_lib Function invoked with incorrect arguments for function, please fix

@hugueskamba
Copy link
Collaborator Author

Travis failed: mbed_set_printf_lib Function invoked with incorrect arguments for function, please fix

It needs the tools update which will provide the missing variable passed to the function. See "Migration actions required" section in this PR.

@hugueskamba hugueskamba force-pushed the hk_cmake_add_printf_lib_support branch 2 times, most recently from f50d897 to 8eca95b Compare September 16, 2020 16:54
@mergify
Copy link

mergify bot commented Sep 16, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@hugueskamba hugueskamba force-pushed the hk_cmake_add_printf_lib_support branch from 8eca95b to 04e9cd9 Compare September 16, 2020 17:00
@Patater Patater mentioned this pull request Sep 17, 2020
Closed
@mergify
Copy link

mergify bot commented Sep 17, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

0xc0170
0xc0170 previously approved these changes Sep 17, 2020
View reviewed changes
@hugueskamba hugueskamba force-pushed the hk_cmake_add_printf_lib_support branch from 04e9cd9 to 8f4956c Compare September 17, 2020 15:45
@mergify mergify bot dismissed 0xc0170’s stale review September 17, 2020 15:45

Pull request has been modified.

@hugueskamba hugueskamba merged commit 870f911 into ARMmbed:feature-cmake Sep 18, 2020
@hugueskamba hugueskamba deleted the hk_cmake_add_printf_lib_support branch September 18, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 left review comments

Assignees

No one assigned

Labels

needs: work release-version: feature branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hugueskamba @0xc0170