Skip to content

Conversation

@CharleyChu
Copy link

@CharleyChu CharleyChu commented Sep 28, 2020

Only report the flash region that can be accessed by none-secure CPU

Signed-off-by: Charley Chu [email protected]

Summary of changes

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@mergify mergify bot added the do not merge label Sep 28, 2020
@ciarmcom ciarmcom requested review from a team and maclobdell September 28, 2020 21:30
@ciarmcom
Copy link
Member

@CharleyChu, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

Only report the flash region that can be accessed by none-secure CPU

Signed-off-by: Charley Chu <[email protected]>
@CharleyChu CharleyChu force-pushed the topic/master_cytfm_471 branch from 1c09148 to 57f3626 Compare September 29, 2020 00:11
@Patater
Copy link
Contributor

Patater commented Sep 29, 2020

This seems like an okay approach to me. The immediate question that comes to mind is why not implement the top-level cyhal_flash_get_info() function differently based on TF-M being present or not, rather than at this call site. Perhaps other call sites (pre-existing or added in the future) will need this same ifdef; wouldn't it be nicer for those other call sites to have this difference in implementation abstracted away?

@CharleyChu
Copy link
Author

@Patater Thanks for reviewing this. The CYHAL is a low level device driver library, which doesn't have the memory region information (region_defs.h) defined by TFM, a middle-ware above the CYHAL library.

@CharleyChu CharleyChu changed the title WIP:psoc64: Update flash layout of CYTFM_064B0S2_4343W psoc64: Update flash layout of CYTFM_064B0S2_4343W Oct 2, 2020
@RaymondNgun
Copy link

@ciarmcom, can we please merge this. No longer WIP.

@CharleyChu
Copy link
Author

it appears the build failed with network error. Could you please try again?

===========================
source tools/test/travis-ci/functions.sh
before_install.2
0.49s$ set_status "pending" "Test started."
install.1
11.18s$ curl -L0 https://mbed-os.s3-eu-west-1.amazonaws.com/builds/deps/astyle_3.1_linux.tar.gz --output astyle.tar.gz; mkdir -p BUILD && tar xf astyle.tar.gz -C BUILD; cd BUILD/astyle/build/gcc; make; export PATH="${PWD}/bin:${PATH}"; cd -
install.2
0.00s$ astyle --version
130.59s$ git fetch --all --unshallow --tags
Fetching origin
fatal: unable to access 'https://github.com/ARMmbed/mbed-os.git/': Failed to connect to github.com port 443: Connection timed out
error: Could not fetch origin
The command "git fetch --all --unshallow --tags" failed and exited with 1 during .
Your build has been stopped.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 15, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 15, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Oct 15, 2020
@0xc0170 0xc0170 merged commit ab14eb6 into ARMmbed:master Oct 15, 2020
@mergify mergify bot removed the ready for merge label Oct 15, 2020
@mbedmain mbedmain added release-version: 6.4.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants