Skip to content

Conversation

@0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Sep 30, 2020

Summary of changes

Protect kvstore headers as well as they should not be included if kvstore is not enabled
in nanostack file system.

I found this when I enabled nanostack with CMake but kvstore was not, this would cause a compilation error eventhough the conf for filesystem was set to 0.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@artokin

Protect kvstore headers as well as they should not be included if kvstore is not enabled
in nanostack file system.
@mergify mergify bot added the needs: CI label Sep 30, 2020
@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 30, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 30, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_wisun-mesh-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Sep 30, 2020
@0xc0170 0xc0170 merged commit aa9989f into ARMmbed:master Sep 30, 2020
@mergify mergify bot removed the ready for merge label Sep 30, 2020
@0xc0170 0xc0170 deleted the fix_nanostack_kvstore branch September 30, 2020 14:54
@mbedmain mbedmain added release-version: 6.4.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants