Skip to content

Fix ESP8266 #13707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2020
Merged

Fix ESP8266 #13707

merged 1 commit into from
Oct 15, 2020

Conversation

@paul-szczepanek-arm
Copy link
Member

@paul-szczepanek-arm paul-szczepanek-arm commented Oct 2, 2020 •
edited
Loading

Summary of changes

Fix not initialised member in one of the constructors.

Impact of changes

Migration actions required

Documentation

none

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@pan-

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Oct 2, 2020
@ciarmcom ciarmcom requested review from a team and pan- October 2, 2020 16:30
@ciarmcom
Copy link
Member

ciarmcom commented Oct 2, 2020

@paul-szczepanek-arm, thank you for your changes.
@pan- @ARMmbed/mbed-os-maintainers please review.

@paul-szczepanek-arm paul-szczepanek-arm mentioned this pull request Oct 5, 2020
Closed
moshe-shahar
moshe-shahar reviewed Oct 5, 2020
View reviewed changes
connectivity/drivers/wifi/esp8266-driver/mbed_lib.json Outdated
"target_overrides": {
"HEXIWEAR": {
"*": {
"target.printf_lib": "std"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compilation error:

[ERROR] Attempt to override undefined parameter 'target.printf_lib' in 'library:esp8266[*]'

https://github.com/ARMmbed/mbed-os/pull/13707/files#diff-72daba8ef643af857ee7d9ec1b681b23R96

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, this is embarassing, it would've helped if I compiled for a target that actually uses esp8266

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use the reproducing steps in #13687 issue description:

@moshe-shahar
Copy link
Contributor

What is the status of that PR?
It has a partial fix for #13687.

Can it be merged?

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 15, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 15, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit 2776687 into ARMmbed:master Oct 15, 2020
@mergify mergify bot removed the ready for merge label Oct 15, 2020
@mbedmain mbedmain added release-version: 6.4.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@pan- pan- Awaiting requested review from pan-

+1 more reviewer

@moshe-shahar moshe-shahar moshe-shahar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 6.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@paul-szczepanek-arm @ciarmcom @moshe-shahar @0xc0170 @mbed-ci @mbedmain