Add workaround for files with permissive binary licenses #13847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
reviewed
Nov 3, 2020
harmut01
force-pushed
the
pbl_scancode_fix
branch
from
d49d6ed to
a07e39f
Compare
hugueskamba
reviewed
Nov 3, 2020
harmut01
force-pushed
the
pbl_scancode_fix
branch
from
a07e39f to
2629deb
Compare
Add function "has_binary_license" to check if a file has a non-permissive license contains one. PBL is not recognized by scancode, causing it to be flagged as a non-permissive license. CI doesn't allow any non-permissive licenses, although, files flageed as SPDX are allowed. Workaround causes all files with a valid PBL to be flagged as missing an SPDX. Add condition in "has_spdx_text_in_scancode_output" to ignore any spdx identifier with "unknown" in the name. Scancode erroneously matches PBL to matched_rule.identifer "spdx-license-identifier: unknown-spdx". This prevents the workaround from working.
harmut01
force-pushed
the
pbl_scancode_fix
branch
from
2629deb to
d085e9f
Compare
0xc0170
previously approved these changes
Nov 4, 2020
|
@hugueskamba I've pushed new changes that should address some of your points. |
hugueskamba
previously requested changes
Nov 5, 2020
mergify
bot
dismissed stale reviews from 0xc0170 and hugueskamba
Pull request has been modified.
harmut01
force-pushed
the
pbl_scancode_fix
branch
from
383e5bb to
3c97713
Compare
hugueskamba
reviewed
Nov 6, 2020
harmut01
force-pushed
the
pbl_scancode_fix
branch
2 times, most recently
from
74ab164 to
224d87a
Compare
|
@hugueskamba @0xc0170 please see the latest changes for your review. |
0xc0170
previously approved these changes
Nov 6, 2020
hugueskamba
reviewed
Nov 6, 2020
harmut01
force-pushed
the
pbl_scancode_fix
branch
from
224d87a to
e2de080
Compare
hugueskamba
reviewed
Nov 6, 2020
Add function "has_binary_license" to check if a file has a non-permissive license contains one. PBL is not recognized by scancode, causing it to be flagged as a non-permissive license. CI doesn't allow any non-permissive licenses, although, files flageed as SPDX are allowed. Workaround causes all files with a valid PBL to be flagged as missing an SPDX. Add condition in "has_spdx_text_in_scancode_output" to ignore any spdx identifier with "unknown" in the name. Scancode erroneously matches PBL to matched_rule.identifer "spdx-license-identifier: unknown-spdx". This prevents the workaround from working.
harmut01
force-pushed
the
pbl_scancode_fix
branch
from
e2de080 to
e93a3e2
Compare
hugueskamba
approved these changes
Nov 6, 2020
0xc0170
approved these changes
Nov 9, 2020
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.5.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes #13840
Add function for checking that files with Permissive Binary Licenses are not erroneously flagged as missing permissive licenses. Scancode does not currently have our license in its database as PBL is not a recognized SPDX license. This is a temporary solution until we are able to get the license into a scancode toolkit release.
Impact of changes
Affects CI, files with PBL licenses
Migration actions required
None
Documentation
None
Pull request type
Test results
Reviewers
@0xc0170 @hugueskamba @ARMmbed/mbed-os-maintainers