Skip to content

Conversation

@UbiJCC
Copy link
Contributor

@UbiJCC UbiJCC commented Mar 6, 2021

Summary of changes

Added extern "C" around functions in am_hal_secure_ota.h.

This change is necessary to use the Apollo3's Secure OTA functionality within mbed.

Fixes #14389

Impact of changes

Users may now call the functions declared in am_hal_secure_ota.h where they could not before.

Migration actions required

None

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just one header (the rest of files in hal/ are ok?)

@mergify mergify bot added the needs: CI label Mar 8, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 8, 2021

Is this just one header (the rest of files in hal/ are ok?)

I've checked few other files under hal directory, they look good.

@UbiJCC
Copy link
Contributor Author

UbiJCC commented Mar 8, 2021

Is this just one header (the rest of files in hal/ are ok?)

I have checked every header file under the TARGET_APOLLO3/sdk/mcu/apollo3/hal/ directory and can confirm this is the only header file (which declares any functions) missing the extern "C" declaration.

The only concern I have is that these files may be taken directly from AmbiqSuite SDK, and this change may (further?) diverge us, but frankly it seems this is an oversight in Ambiq's HAL in the first place.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 8, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 8, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Mar 9, 2021
@0xc0170 0xc0170 merged commit 682a5ea into ARMmbed:master Mar 9, 2021
@mergify mergify bot removed the ready for merge label Mar 9, 2021
@mbedmain mbedmain added release-version: 6.9.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apollo3's am_hal_secure_ota.h has no "extern C" before method declarations

4 participants