STM32: Fixed I2C Bug #14698
Merged
STM32: Fixed I2C Bug #14698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
affrinpinhero-2356
force-pushed
the
HAL_I2C_ErrorCallback-#14696
branch
from
ff24a72 to
fbc7da1
Compare
|
@affrinpinhero-2356, thank you for your changes. |
|
@affrinpinhero-2356 looks like you have a conflict as well as needing to update the PR header |
jeromecoutant
approved these changes
May 25, 2021
Modified HAL_I2C_ErrorCallback function to solve bug reported in I2C Driver. This commit solves compilation error occured when DEVICE_I2CSLAVE is not defined. fix ARMmbed#14696 Signed-off-by: Affrin Pinhero <[email protected]>
affrinpinhero-2356
force-pushed
the
HAL_I2C_ErrorCallback-#14696
branch
from
fbc7da1 to
67a3834
Compare
jeromecoutant
approved these changes
May 25, 2021
affrinpinhero-2356
changed the title
|
@jeromecoutant Have any idea for the failure? |
|
I don't know... |
Modified HAL_I2C_ErrorCallback function to solve bug reported in I2C Driver. This commit solves compilation error occured when DEVICE_I2CSLAVE is not defined. fix ARMmbed#14696 Signed-off-by: Affrin Pinhero <[email protected]>
Modified HAL_I2C_ErrorCallback function to solve bug reported in I2C Driver. This commit solves compilation error occured when DEVICE_I2CSLAVE is not defined. fix ARMmbed#14696 Signed-off-by: Affrin Pinhero <[email protected]>
|
@jeromecoutant Is this good to start CI? |
I don't have this power :-) |
affrinpinhero-2356
requested review from
jeromecoutant
and removed request for
a team
jeromecoutant
approved these changes
May 31, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
0xc0170
approved these changes
May 31, 2021
0xc0170
added
ready for merge
release-type: patch
|
@affrinpinhero-2356 please keep the pull request template (Pull request type for instance looks it was edited), not certain if this time a script could not parse proper info or there is some other issue (I'll check other pull requests to confirm) but to be on the safe side, lets keep the template as it is. |
mbedmain
added
release-version: 6.12.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Modified HAL_I2C_ErrorCallback function to solve bug reported in I2C Driver.
This commit solves compilation error occured when DEVICE_I2CSLAVE is not defined.
Impact of changes
Migration actions required
Documentation
Pull request type:
[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)
Test results:
[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR
Reviewers