-
Notifications
You must be signed in to change notification settings - Fork 3k
add workflow for checking ble feature selection compilation #14927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Runs on my fork: |
@paul-szczepanek-arm, thank you for your changes. |
Maybe we can combine this with #14919 . After all this verifies that the conditional compilation has been fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can run it for every PR that touches BLE: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#onpushpull_requestpaths .
@@ -0,0 +1,28 @@ | |||
name: run conditional BLE feature compilation | |||
on: | |||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so we can run it on BLE PRs.
This is still due (I don't see push attribute there)? |
OK, I changed it to run on each PR instead of weekly. It does run a dozen compiles but then again we're not paying for that :D |
This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged. |
CI started |
Summary of changes
This is a new workflow for github to add a new test in CI that checks BLE conditional compilation. Some BLE features can be toggled on or off, this makes sure it the project still compiles with different features toggled.
Impact of changes
Migration actions required
Documentation
none
Pull request type
Test results
Reviewers