Fix lp1114 flash overflow issue #15076
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwalton-arm
reviewed
Sep 16, 2021
rajkan01
force-pushed
the
fix_lp1114_flash_overflow_issue
branch
from
5535931 to
a391837
Compare
rajkan01
force-pushed
the
fix_lp1114_flash_overflow_issue
branch
from
a391837 to
43784bc
Compare
- ROM size is required in callback_big and compliance printf greeentea test for finding out the number of test cases to be enabled to avoid flash overflow, but when we copy the "mbed-rom-size" config from index.json to targets.json causes the build failure for LPC1114 as MBED CLI1 expects that if any of the mem (ROM, RAM) configs are present in targets.json should have bootloader support, hence introducing new rom-size using "config" in LPC1114 in targets.json to generate MBED_CONF_TARGET_ROM_SIZE by Mbed CLI1 and Mbed CLI2 macro which can be used in the greentea test. - Add new rom-size config to the 15 targets which already have mbed_rom_size config in "targets.json"
…nary size The "minimal_printf" greentea test has test cases for the different data types (%d, %u, %x, %ld, %lu, %lx %llx) that require a minimum above 36kb ROM to build all test cases. LPC1114 target has only 32KB ROM memory, so these changes excluding 3 test cases of data types %lld, %llu, %llx to bring down to meet target minimum ROM size
rajkan01
force-pushed
the
fix_lp1114_flash_overflow_issue
branch
from
43784bc to
b712589
Compare
Patater
reviewed
Sep 17, 2021
| #define LLONG_MIN INT64_MIN | ||
| #endif | ||
|
|
||
| #define TEST_MIN_REQ_ROM_SIZE (36 * 1024) |
There was a problem hiding this comment.
Is 36 KiB enough to run the tests?
There was a problem hiding this comment.
Yes probably enough
|
This pull request has automatically been marked as stale because it has had no recent activity. @rwalton-arm, @Patater, please complete review of the changes to move the PR forward. Thank you for your contributions. |
0xc0170
added
the
release-type: patch
|
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
|
We are closing this pull request due to inactivity |
mergify
bot
removed
needs: work
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
mbed_rom_sizeconfig in "targets.json"Impact of changes
With these changes, minimal_printf greentea test can avoid overflow ROM issue
Migration actions required
None.
Documentation
None.
Pull request type
Test results
Reviewers