[LPC824] Fixed PwmOut SCT Bugs #1585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed period & pulse-width off-by-one errors * Fixed 0% and 100% duty cycle output
| obj->pwm->MATCHREL[(obj->pwm_ch * 2) + 1] = (uint32_t)((float)us * (float)v); | ||
| obj->pwm->MATCHREL[(obj->pwm_ch * 2) + 0] = (uint32_t)us - 1; | ||
| if (us > 0) { | ||
| obj->pwm->MATCHREL[(obj->pwm_ch * 2) + 1] = (uint32_t)((float)us * (float)v) - 1; |
There was a problem hiding this comment.
would it be beneficial to add comments why us > 0 , what it handles, or lines like below obj->pwm->CTRL |= (1 << 2) | (1 << 3); ? I without the reference manual have no clue what is going on. From the commit message, off by one errors are probably for lines 158 and 159, and then if (value != 1.0f) is probably for 100 percent error (also from the commit message).
|
Thank you for your comment. I added more comments in the code. Can you review? |
+1 , we should understand the intention better now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixes related to issue #1510:
I have tested this with manual test and MBED_5: PWM test: