Patch of #2318 #2332
Merged
Patch of #2318 #2332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having the echo tests generate any random character caused issues serializing the test output into an xml file. This change limits the characters generated by the device to '0' - '9'.
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 576 All builds and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is derived from #2318. This attempts to fix an issue that occurs in earlier version of Python when generating XML test reports.
The TCP and UDP echo test cases generate random ASCII sequences to be echoed back by the host PC. In the case where a test report needs to be generated, this causes the following error:
This PR avoids this issue by limiting the range of random ASCII characters to just '0' - '9'. This should be sufficiently random but use safer characters that shouldn't cause issues when saving to XML files.
FYI @sg-