Fix exported project file group naming #2659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous way of finding group names found the encompassing directory of each file. If the project is exported from the online compiler, this resulted in temporary folder names like tmpyKKWv_ showing up as group names. I propose defaulting to the project name if the file is in the project root.
sarahmarshy
changed the title
|
LGTM 👍 |
|
LGTM |
|
CC @sg- |
|
/morph export-build |
Result: FAILUREYour command has finished executing! Here's what you wrote!
|
|
@sarahmarshy There are failures for IAR, please have a look |
|
@bridadan is this a regression? |
|
@0xc0170 I don't see any regressions from previous IAR failures. |
Is this tracked that this needs to be fixed? I was not aware of them, thus pinpointed it above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous way of finding group names found the encompassing directory of each file. If the project is exported from the online compiler, this resulted in temporary folder names like tmpyKKWv_ showing up as group names in offline IDEs.
I propose defaulting to the project name if the file is in the project root.
@theotherjimmy @screamerbg
Thanks to @bridadan for finding and reporting this issue.