Skip to content

Conversation

c1728p9
Copy link
Contributor

@c1728p9 c1728p9 commented Oct 12, 2016

Add a small build profile and general docs for build profiles.

@c1728p9
Copy link
Contributor Author

c1728p9 commented Oct 13, 2016

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 0

Build Prep failed!

@bridadan
Copy link
Contributor

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 0

All builds and test passed!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also or just use --profile as it's much user-friendly than path_to_profiles/ ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, what about user provided profiles ? Are they still supported ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if the 3 built-in profiles could be used without specifying the full path. This isn't the case currently though, so the docs should be updated in the PR that makes this change. In that case I would vote for keeping user provided profiles.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it is, my change was merged week ago you can pass only the profile name eg debug as long as it's in the mbed-os/tools/profiles/*.json and the full path still works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah cool, then I'll update the docs here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this, I am missing which build is what usually SDK has "release build", are small and default to be considered release ("Hard to follow code flow when using a debugger") . Or to state that optimizations are enabled, that would be a good hint for users?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you are asking here. Everything by default will be using the default profile. The Default and Small profiles are for ideal for release builds, but even a debug build could be released if the slower speed and larger code size isn't a problem.

c1728p9 and others added 2 commits October 18, 2016 09:23
Add a small build profile and general docs for build profiles.
Remove profiles which are not suitable for building stand alone. This
leaves just the 3 core profiles.
@c1728p9
Copy link
Contributor Author

c1728p9 commented Oct 18, 2016

Rebased and updated the docs to get rid of the path to the profile.

@c1728p9
Copy link
Contributor Author

c1728p9 commented Oct 25, 2016

/morph test

Copy link
Contributor

@geky geky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think this provides the most reasonable set of default profiles that users can reason about.

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 946

All builds and test passed!

@bulislaw
Copy link
Member

LGTM as well.

@0xc0170 0xc0170 merged commit 4198222 into ARMmbed:master Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants