Remove unused arguments from detect targets #3439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theotherjimmy
force-pushed
the
detect-targets-args
branch
from
57f1659 to
1bc0873
Compare
bridadan
reviewed
Dec 13, 2016
tools/detect_targets.py
Outdated
There was a problem hiding this comment.
Nit: Any reason why the default value for the --filter argument can't be ".*"?
It seems kind of odd to accept an array of regex expressions. Wouldn't you just change your regex to be more accommodating?
Also, the current ArgParse option will set options.general_filter_regex to just a string, not an array. Won't this blow up below?
theotherjimmy
force-pushed
the
detect-targets-args
branch
from
1bc0873 to
23461ee
Compare
0xc0170
approved these changes
Dec 16, 2016
bridadan
approved these changes
Dec 16, 2016
|
As far as I know, none of the CI scripts hit this script, but I'll run the basic one just in case. /morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
Ready pending review from @adbridge |
adbridge
approved these changes
Dec 19, 2016
0xc0170
added
ready for merge
release-version: 5.3.2
and removed
needs: review
ready for merge
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Todos
mbed detectstill works and thatmbed detect -fworksResolves #1996