Thread config update #3736
Merged
Thread config update #3736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 10, 2017
|
If Travis doesn't merge with master you'll need to rebase this to get the fix that had to do with USB and STM folder renames. |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
@karsev Please resolve conflicts |
|
@SeppoTakalo please review |
SeppoTakalo
approved these changes
Feb 21, 2017
There was a problem hiding this comment.
I'm OK with the change.
Hoewever, I would propose that going forward, we would get rid of the whole
#if defined MBED_CONF_MBED_MESH_API..
#define MBED_MESH_API...
#else
...
Because its pointless. Defaults are written in mbed_lib.json and you should not remove them. So those parameters cannot be absent. We should address this maybe in some patch release after 5.4.
For now, its OK.
kseverinkangas-zg
force-pushed
the
thread_config_update
branch
from
fa7074f to
52ca190
Compare
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New Thread network configurations (in mesh-api) to be taken into use in the mbed-os 5.4 release.
Status
READY
Related PRs
List related PRs against other branches:
Todos
Steps to test or reproduce
To be tested with the Thread border router (https://github.com/ARMmbed/k64f-border-router-private) and the example applications using mesh-api. Pull requests available ->
ARMmbed/mbed-os-example-mesh-minimal#45
ARMmbed/mbed-os-example-client#177