Skip to content

Conversation

@gorazdko
Copy link
Contributor

@gorazdko gorazdko commented Jan 17, 2018

Abstract

ff_lpc546xx currently inherits from target lpc546xx. This results in error in mbed online compiler:

Error: Library name 'platform' is not unique (defined in '/extras/mbed_7130f322cb7e/TARGET_LPC546XX/mbed_lib.json' and '/extras/mbed_7130f322cb7e/TARGET_FF_LPC546XX/mbed_lib.json')

when compiling examples with mbed library (compiling with mbed-os works fine).

Status: READY

Priority: High

@mbed-ci
Copy link

mbed-ci commented Jan 17, 2018

Automatic CI verification build not done, please verify manually.

@gorazdko
Copy link
Contributor Author

cc @ashok-rao

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this label needed and not present in the parent, neither LPC546XX does need it?

Copy link
Contributor Author

@gorazdko gorazdko Jan 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, both targets need it (target LPC546XX adds it by default)

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 18, 2018

ff_lpc546xx currently inherits from target lpc546xx. This results in error in mbed online compiler:

Still causing the problems with the latest update?

@gorazdko
Copy link
Contributor Author

It doesnt work with mbed version 157.

I havent tested 242ce29 against the error. How do i point online compiler to it?

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 19, 2018

I havent tested 242ce29 against the error. How do i point online compiler to it?

you can fork mbed-os there and use your own modified version for instance

gorazdko added a commit to gorazdko/mbed that referenced this pull request Jan 19, 2018
@gorazdko
Copy link
Contributor Author

you can fork mbed-os there and use your own modified version for instance

yes i am familiar with that. Although i need to fork mbed (not mbed-os). So i need to fork this with source files. Where is the fork button?
If i import it into compiler and fork from there it only forks precompiled build (no source).

Anyway, i moved the mbed repo to github and imported the lib from there. This PR does not solve the error:

fix_not_working

@gorazdko
Copy link
Contributor Author

Changing device name does not work either:
mbed_3

It does work if i remove or rename the LPC546XX folder:
mbed_5

I am closing this PR and opening an issue for that.

@mbed-ci
Copy link

mbed-ci commented Feb 5, 2018

User not whitelisted, CI not run.

@gorazdko
Copy link
Contributor Author

gorazdko commented Feb 5, 2018

Reopening this PR. See #5887.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 5, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 5, 2018

Build : SUCCESS

Build number : 1060
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5876/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Feb 5, 2018

@mbed-ci
Copy link

mbed-ci commented Feb 5, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 5, 2018

network error for one device, restarting

/morph test

@cmonr
Copy link
Contributor

cmonr commented Feb 5, 2018

@gorazdko This is going to need a rebase to resolve a conflict.

Fixes #5887

@mbed-ci
Copy link

mbed-ci commented Feb 5, 2018

@gorazdko
Copy link
Contributor Author

gorazdko commented Feb 6, 2018

rebased

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 6, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 6, 2018

Build : SUCCESS

Build number : 1070
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5876/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Feb 6, 2018

@mbed-ci
Copy link

mbed-ci commented Feb 6, 2018

@cmonr cmonr merged commit 2d05258 into ARMmbed:master Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants