Skip to content

Add support for GD32_E103VB #9199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add support for GD32_E103VB #9199

wants to merge 2 commits into from

Conversation

ChazJin
Copy link
Contributor

@ChazJin ChazJin commented Dec 26, 2018

Description

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

CC @Ronny-Liu @0xc0170 thanks a lot!

@ciarmcom ciarmcom requested review from a team, 0xc0170 and Ronny-Liu December 26, 2018 12:00
@ciarmcom
Copy link
Member

@ChazJin, thank you for your changes.
@0xc0170 @Ronny-Liu@ARMmbed/mbed-os-maintainers please review.

Ronny-Liu
Ronny-Liu suggested changes Dec 27, 2018
View reviewed changes
Copy link
Contributor

@Ronny-Liu Ronny-Liu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate new targets in multiple PRs

@ChazJin ChazJin changed the title Add support for GD32_F450ZI and GD32_E103VB Add support for GD32_E103VB Dec 27, 2018
@ChazJin ChazJin mentioned this pull request Dec 27, 2018
Merged
@ChazJin
Copy link
Contributor Author

ChazJin commented Dec 28, 2018

Close it because we have added the information about GD32_E103VB into target.json in #9203

@ChazJin ChazJin closed this Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 Awaiting requested review from 0xc0170

1 more reviewer

@Ronny-Liu Ronny-Liu Ronny-Liu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ChazJin @ciarmcom @Ronny-Liu @studavekar