Skip to content

lwipstack: mem-size set to the to minimal working size with DTLS #9471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2019
Merged

lwipstack: mem-size set to the to minimal working size with DTLS #9471

merged 1 commit into from
Jan 31, 2019

Conversation

mtomczykmobica
Copy link

… DTLS

Description

Modiefie mem-size parameter to minimal size that work with DTLS

Pull request type

[x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@0xc0170 0xc0170 changed the title Modiefie mem-size parameter to minimal size that work with… lwipstack: mem-size set to the to minimal working size Jan 23, 2019
@0xc0170 0xc0170 changed the title lwipstack: mem-size set to the to minimal working size lwipstack: mem-size set to the to minimal working size with DTLS Jan 23, 2019
@ciarmcom ciarmcom requested review from a team January 23, 2019 14:00
@ciarmcom
Copy link
Member

@mtomczykmobica, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@SeppoTakalo
Copy link
Contributor

Did you test these values also with TLSSocket?

@mtomczykmobica
Copy link
Author

Yes, tested with TLS too. (--tc DTLS,DTLS_NONBLOCK,TLSSOCKET_HANDSHAKE,TLSSOCKET_ECHOTEST,TCPSOCKET_ECHOTEST)

@SeppoTakalo
Copy link
Contributor

Good.

@cmonr
Copy link
Contributor

cmonr commented Jan 30, 2019

@mtomczykmobica Curious. Why the large min-size difference between families?

@cmonr
Copy link
Contributor

cmonr commented Jan 31, 2019

CI started

@SeppoTakalo
Copy link
Contributor

Because some Ethernet drivers allocate large ring buffers from LwIP stack.

@mbed-ci
Copy link

mbed-ci commented Jan 31, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 695179b into ARMmbed:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@cmonr cmonr cmonr approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@michalpasztamobica michalpasztamobica michalpasztamobica approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.11.4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mtomczykmobica @ciarmcom @SeppoTakalo @cmonr @mbed-ci @michalpasztamobica @0xc0170