Skip to content

Fix cortex-m33-S gcc compilation error #9614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2019
Merged

Fix cortex-m33-S gcc compilation error #9614

merged 1 commit into from
Feb 7, 2019

Conversation

mikisch81
Copy link
Contributor

@mikisch81 mikisch81 commented Feb 5, 2019 •
edited by adbridge
Loading

Description

Fixes cortex-m33-S gcc compilation error due to a bug in gcc.py (Issue #9608).

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@deepikabhavnani @ARMmbed/mbed-os-tools

Fix cortex-m33-S compile error
0e7d172 
Compilation error was due to due to bug in gcc.py
deepikabhavnani
deepikabhavnani approved these changes Feb 5, 2019
View reviewed changes
Copy link

@deepikabhavnani deepikabhavnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing

@NirSonnenschein
Copy link
Contributor

starting CI

bridadan
bridadan approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@mikisch81 mikisch81 mentioned this pull request Feb 5, 2019
Closed
@mbed-ci
Copy link

mbed-ci commented Feb 5, 2019

Test run: FAILED

Summary: 2 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM

@alekla01
Copy link
Contributor

alekla01 commented Feb 5, 2019

restarted ci

@mbed-ci
Copy link

mbed-ci commented Feb 5, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@mikisch81
Copy link
Contributor Author

@ARMmbed/mbed-os-maintainers Can it be merged?

@mikisch81 mikisch81 mentioned this pull request Feb 6, 2019
Merged
@NirSonnenschein
Copy link
Contributor

Hi @mikisch81,
please write a proper description for the PR.

@mikisch81 mikisch81 changed the title Fix cortex-m33-S compile error Fix cortex-m33-S gcc compilation error Feb 6, 2019
@mikisch81
Copy link
Contributor Author

Hi @mikisch81,
please write a proper description for the PR.

Isn't the link to the issue is enough?

@mikisch81
Copy link
Contributor Author

@NirSonnenschein Updated the description.

@0xc0170 0xc0170 merged commit 9bda449 into ARMmbed:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+3 more reviewers

@theotherjimmy theotherjimmy theotherjimmy approved these changes

@bridadan bridadan bridadan approved these changes

@deepikabhavnani deepikabhavnani deepikabhavnani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.11.4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mikisch81 @NirSonnenschein @mbed-ci @alekla01 @theotherjimmy @0xc0170 @bridadan @deepikabhavnani