Skip to content

Pinmap design doc #9690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 19, 2019
Merged

Pinmap design doc #9690

merged 9 commits into from
Feb 19, 2019

Conversation

@c1728p9
Copy link
Contributor

@c1728p9 c1728p9 commented Feb 12, 2019

Description

I couldn't push to #8693 so I opened this to make updates to the pinmap design document.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[x] Docs update
[ ] Test update
[ ] Breaking change

@c1728p9
Copy link
Contributor Author

c1728p9 commented Feb 12, 2019

Make the following changes from #8693:

  • Update design doc content
  • Updated design doc to follow the template
  • Rebased onto master

PR which brought pinmap main-line is #9449 .

Docs for pinmap can be found in ARMmbed/mbed-os-5-docs#930.

@c1728p9
Copy link
Contributor Author

c1728p9 commented Feb 12, 2019

@ithinuel @bulislaw @donatieng @SenRamakri @0xc0170 @cmonr please review.

@c1728p9 c1728p9 mentioned this pull request Feb 12, 2019
Closed
@ciarmcom ciarmcom requested review from a team February 12, 2019 22:00
@ciarmcom
Copy link
Member

@c1728p9, thank you for your changes.
@ARMmbed/mbed-os-hal @ARMmbed/mbed-os-maintainers please review.

@ciarmcom
Copy link
Member

@c1728p9, thank you for your changes.
@ARMmbed/mbed-os-hal @ARMmbed/mbed-os-maintainers please review.

cmonr
cmonr reviewed Feb 12, 2019
View reviewed changes
fkjagodzinski
fkjagodzinski suggested changes Feb 13, 2019
View reviewed changes
Copy link
Member

@fkjagodzinski fkjagodzinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one thing to fix.

Cruz Monrreal and others added 2 commits February 13, 2019 09:00
@c1728p9
Make targets plural in design document
c2a67f3 
Co-Authored-By: c1728p9 <[email protected]>
@c1728p9
Update table of content links
b63b302 
Update the links and names in the table of contents.
@cmonr cmonr requested a review from AnotherButler February 13, 2019 20:43
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 19, 2019

@AnotherButler Please review

@cmonr
Copy link
Contributor

cmonr commented Feb 19, 2019 •
edited
Loading

CI started whilst final review comes in

@cmonr
Copy link
Contributor

cmonr commented Feb 19, 2019

Bringing in now to unblock other PRs that might be dependent on this.

@AnotherButler will submit a seperate PR for doc fixes if needed.

@cmonr cmonr merged commit f4e6db2 into ARMmbed:master Feb 19, 2019
@c1728p9 c1728p9 deleted the pinmap-design-doc branch March 7, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@AnotherButler AnotherButler Awaiting requested review from AnotherButler

+2 more reviewers

@cmonr cmonr cmonr approved these changes

@fkjagodzinski fkjagodzinski fkjagodzinski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.12.0-rc1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@c1728p9 @ciarmcom @0xc0170 @cmonr @fkjagodzinski @ithinuel