Skip to content

Conversation

naveenkaje
Copy link
Contributor

Description

Fix this build warning seen when building with ARMCC

Compile [ 13.7%]: UBLOX_AT_CellularNetwork.cpp
[Warning] UBLOX_AT_CellularNetwork.cpp@65,0:  #111-D: statement is unreachable

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Fix this build warning seen when building with ARMCC

Compile [ 13.7%]: UBLOX_AT_CellularNetwork.cpp
[Warning] UBLOX_AT_CellularNetwork.cpp@65,0:  ARMmbed#111-D: statement is unreachable
@ciarmcom ciarmcom requested review from a team February 12, 2019 22:00
@ciarmcom
Copy link
Member

@naveenkaje, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom
Copy link
Member

@naveenkaje, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh, that's a funky warning to get rid of.

Makes sense to me.

@cmonr
Copy link
Contributor

cmonr commented Feb 12, 2019

CI started whist final review comes in.

Betting on reviewer being OK with changes

@mbed-ci
Copy link

mbed-ci commented Feb 13, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit e310458 into ARMmbed:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants