Skip to content

Add release notes section to PR template #9713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2019
Merged

Add release notes section to PR template #9713

merged 1 commit into from
Feb 14, 2019

Conversation

orenc17
Copy link
Contributor

@orenc17 orenc17 commented Feb 13, 2019 •
edited by 0xc0170
Loading

Description

Never miss your release notes again

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-maintainers @AnotherButler

Release Notes

@AnotherButler
Copy link
Contributor

I think this is a fantastic idea. I hope you don't mind - I've copy edited this and added a link to the relevant documentation.

@ciarmcom ciarmcom requested review from a team and AnotherButler February 13, 2019 20:00
@ciarmcom
Copy link
Member

@orenc17, thank you for your changes.
@AnotherButler @ARMmbed/mbed-os-maintainers please review.

@cmonr
Copy link
Contributor

cmonr commented Feb 13, 2019

The user(s) have spoken!

Tbh, I thought this was already added. Looking for OKs from other @ARMmbed/mbed-os-maintainers

0xc0170
0xc0170 reviewed Feb 14, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! we were going to add this, should be in ! 👍

One small cosmetic edit, please add space as other sections has it (after header , one empty line).

0xc0170
0xc0170 reviewed Feb 14, 2019
View reviewed changes
.github/pull_request_template.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adbridge Just to check to have this implemented - we documented in docs that any functional change, but rather as it's here that even bigger refactors or breaking change (it's functionality change but has it's own item) can have release notes, would make this requirement: script should check any PR for release notes and fetch them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plase add

Should say 'please add'

adbridge
adbridge requested changes Feb 14, 2019
View reviewed changes
.github/pull_request_template.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plase add

Should say 'please add'

@AnotherButler
Copy link
Contributor

Good catch @adbridge
Thanks 👍

@cmonr
Copy link
Contributor

cmonr commented Feb 14, 2019

CI started

@cmonr cmonr merged commit c3229ee into ARMmbed:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@adbridge adbridge adbridge approved these changes

@AnotherButler AnotherButler Awaiting requested review from AnotherButler

+2 more reviewers

@cmonr cmonr cmonr approved these changes

@NirSonnenschein NirSonnenschein NirSonnenschein approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.11.5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@orenc17 @AnotherButler @ciarmcom @cmonr @0xc0170 @adbridge @NirSonnenschein