Skip to content

Only GCC_ARM toolchain is supported, removing legacy code #9714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2019
Merged

Only GCC_ARM toolchain is supported, removing legacy code #9714

merged 1 commit into from
Feb 15, 2019

Conversation

@deepikabhavnani
Copy link

Description

GCC_CR / GCC_CWL and all other flavors of GCC are not supported in Mbed OS. Removing the linker files not in use.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SenRamakri

@cmonr cmonr requested review from a team and SenRamakri February 13, 2019 22:40
cmonr
cmonr approved these changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds sensible to me.

0xc0170
0xc0170 approved these changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup

mmahadevan108
mmahadevan108 approved these changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@mmahadevan108 mmahadevan108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@cmonr
Copy link
Contributor

cmonr commented Feb 14, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 14, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 5701c94 into ARMmbed:master Feb 15, 2019
@cmonr
Copy link
Contributor

cmonr commented Feb 21, 2019

Unsure why, but this PR didn't like being applied to the mbed-os-5.11 branch. Retargeting for 5.12.

@mmahadevan108 mmahadevan108 mentioned this pull request Feb 22, 2019
Merged
@deepikabhavnani deepikabhavnani deleted the cleanup_linker_files branch March 1, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@SenRamakri SenRamakri Awaiting requested review from SenRamakri

+2 more reviewers

@cmonr cmonr cmonr approved these changes

@mmahadevan108 mmahadevan108 mmahadevan108 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.12.0-rc1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@deepikabhavnani @cmonr @mbed-ci @0xc0170 @mmahadevan108