Skip to content

Conversation

@paul-szczepanek-arm
Copy link
Member

@paul-szczepanek-arm paul-szczepanek-arm commented Feb 19, 2019

Description

Fixed member initialisation order which will result in a warning or even error depending on compiler.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@donatieng

@paul-szczepanek-arm paul-szczepanek-arm changed the title fixed initialisation order BLE: fixed initialisation order Feb 19, 2019
@paul-szczepanek-arm paul-szczepanek-arm changed the title BLE: fixed initialisation order BLE: fixed initialisation order in GattServer Feb 19, 2019
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😁

@cmonr cmonr requested a review from donatieng February 19, 2019 17:53
@cmonr
Copy link
Contributor

cmonr commented Feb 19, 2019

@donatieng A quick one 😃

@cmonr
Copy link
Contributor

cmonr commented Feb 19, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 19, 2019

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@cmonr
Copy link
Contributor

cmonr commented Feb 19, 2019

CI job restarted: jenkins-ci/exporter

Failure did not appear to be related to PR.

@cmonr
Copy link
Contributor

cmonr commented Feb 21, 2019

Ah, there we go. This is sitting on top of #9537

Retargeted for 5.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants