Add missing .vscode directory to the zipped export #9947
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Behavior with this change |
|
@theotherjimmy @bridadan Please review. |
|
@naveenkaje, thank you for your changes. |
The zipped project should include the .vscode direcotry.
naveenkaje
force-pushed
the
vscode_zip_export
branch
from
f9b4f82 to
d5ba641
Compare
|
@naveenkaje I've been diving deep down the rabbit hole on this issue trying to figure out why this was an issue in the first place. Turns out there was a bigger issue that this was stemming from. May I suggest closing this one as I'd like to get to the root cause? |
0xc0170
approved these changes
Mar 7, 2019
|
#9967 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The zipped project should include the .vscode directory. This is a fix for #8411
Pull request type