Skip to content

Fixing path comparisons in config tests on Windows #9995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2019
Merged

Fixing path comparisons in config tests on Windows #9995

merged 1 commit into from
Mar 28, 2019

Conversation

bridadan
Copy link
Contributor

@bridadan bridadan commented Mar 7, 2019

Description

The config tests compare some paths to be sure the requires keyword is working correctly. However, on Windows, paths are separated with \ instead of /. This PR normalizes the paths to be consistent before comparing them.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@bridadan bridadan requested a review from theotherjimmy March 7, 2019 20:22
@ciarmcom ciarmcom requested review from a team March 7, 2019 22:01
@ciarmcom
Copy link
Member

ciarmcom commented Mar 7, 2019

@bridadan, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@bridadan bridadan mentioned this pull request Mar 8, 2019
Merged
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 16, 2019

Needs rebase (test will fail, started it before I noticed the conflict)

@adbridge
Copy link
Contributor

@bridadan Can you rebase this please?

@bridadan bridadan force-pushed the fix_config_tests_on_windows branch from ed2c2f5 to 51c1bd3 Compare March 27, 2019 19:35
@bridadan
Copy link
Contributor Author

Done!

@cmonr
Copy link
Contributor

cmonr commented Mar 27, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 28, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@NirSonnenschein
Copy link
Contributor

restarted exporter

cmonr pushed a commit to cmonr/mbed-os that referenced this pull request Mar 28, 2019
Merge pull request ARMmbed#9995 from bridadan/fix_config_tests_on_win…
492d08f 
…dows

Fixing path comparisons in config tests on Windows
@cmonr cmonr merged commit 775a91d into ARMmbed:master Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+1 more reviewer

@theotherjimmy theotherjimmy theotherjimmy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.12.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@bridadan @ciarmcom @0xc0170 @adbridge @cmonr @mbed-ci @NirSonnenschein @theotherjimmy