config: Add OUTPUT_EXT
#242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
=======================================
Coverage 96.96% 96.96%
=======================================
Files 92 92
Lines 2673 2673
=======================================
Hits 2592 2592
Misses 81 81 |
LDong-Arm
added a commit
to LDong-Arm/mbed-os
that referenced
this pull request
Mar 25, 2021
Requires: ARMmbed/mbed-tools#242 The optional `OUTPUT_EXT` field in Mbed OS `targets.json` specifies the format of the output image. This is important because * some targets only support one image format * each post-binary hook outputs one image only This avoids confusion of having both .hex and .bin images generated while only one of them is usable.
LDong-Arm
added a commit
to LDong-Arm/mbed-os
that referenced
this pull request
Mar 25, 2021
Requires: ARMmbed/mbed-tools#242 The optional `OUTPUT_EXT` field in Mbed OS `targets.json` specifies the format of the output image. This is important because * some targets only support one image format * each post-binary hook outputs one image only This avoids confusion of having both .hex and .bin images generated while only one of them is usable.
|
^^^ Is the coverage report expected? I did update |
2 tasks
Looks correct to me. The coverage tool just measures how many lines of Python code were hit. This commit doesn't change any Python code, it just edits the |
rwalton-arm
requested changes
Mar 25, 2021
The optional `OUTPUT_EXT` field in Mbed OS `targets.json` specifies the format of the output image. This is important because * some targets only support one image format * each post-binary hook outputs one image only This avoids confusion of having both .hex and .bin images generated while only one of them is usable. Fixes ARMmbed#216
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #216
The optional
OUTPUT_EXTfield in Mbed OStargets.jsonspecifies the format of the output image. This is important becauseThis avoids confusion of having both .hex and .bin images generated while only one of them is usable.
Note: The CMake change in Mbed OS is ARMmbed/mbed-os#14472
Test Coverage