-
Notifications
You must be signed in to change notification settings - Fork 13
CORE2 target added #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
So this PR is supposed to address 5.15 maintenance branch, |
This PR targets mbed 6. |
// Generic signals namings | ||
LED1 = PE_2, | ||
LED2 = PE_3, | ||
LED3 = PE_4, | ||
|
||
// Standardized button names | ||
BUTTON1 = PG_12, | ||
BUTTON2 = PG_13, | ||
|
||
// I2C & SPI | ||
I2C_SCL = PB_8, /* I2C1 */ | ||
I2C_SDA = PB_9, | ||
SPI_MOSI = PA_7, | ||
SPI_MISO = PA_6, | ||
SPI_SCK = PA_5, | ||
SPI_CS = PB_6, | ||
PWM_OUT = PB_3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pin aliases are supposed to be defined as #define xxx
see https://github.com/ARMmbed/mbed-os/blob/master/hal/include/hal/PinNameAliases.h#L160
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in dee4b5e.
I am sorry, I have updated the README file. |
Rebased. Should be ok now. |
Oups, I merged #15 which makes a conflict again... |
README.md
Outdated
- Green Led on PA10 (LED2) reversed (1=OFF, 0=ON) | ||
- SMD CR2450 battery holder | ||
|
||
# STM32F4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment :-)
Could you add STM32F4 after F1, before L0 ?
TARGET_STM32F4/CMakeLists.txt
Outdated
# Copyright (c) 2020 ARM Limited. All rights reserved. | ||
# SPDX-License-Identifier: Apache-2.0 | ||
|
||
add_subdirectory(TARGET_CORE2 EXCLUDE_FROM_ALL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a new line to make GitHub happy ?
Come to surface again ;-P |
Hi,
Responding to: ARMmbed/mbed-os#14898 (comment)
CORE2 is a board used by ROSbots. A firmware to these robots is open source and uses mbed-os 5.14.x, but I'll probably rewrite it soon to use the latest version of the lib. If you don't mind I can add a link to the firmware code later on. Might be useful for somebody who would want to develop a new application using this framework and looks for some use case in robotics.