Skip to content

Conversation

byq77
Copy link
Contributor

@byq77 byq77 commented Jul 18, 2021

Hi,

Responding to: ARMmbed/mbed-os#14898 (comment)

CORE2 is a board used by ROSbots. A firmware to these robots is open source and uses mbed-os 5.14.x, but I'll probably rewrite it soon to use the latest version of the lib. If you don't mind I can add a link to the firmware code later on. Might be useful for somebody who would want to develop a new application using this framework and looks for some use case in robotics.

@jeromecoutant
Copy link
Contributor

A firmware to these robots is open source and uses mbed-os 5.14.x, but I'll probably rewrite it soon to use the latest version of the lib.

So this PR is supposed to address 5.15 maintenance branch,
or 6.x branch ?
(goal of this repo was supposed to address mbed-os-6 support)

@byq77
Copy link
Contributor Author

byq77 commented Jul 19, 2021

This PR targets mbed 6.

Comment on lines 255 to 271
// Generic signals namings
LED1 = PE_2,
LED2 = PE_3,
LED3 = PE_4,

// Standardized button names
BUTTON1 = PG_12,
BUTTON2 = PG_13,

// I2C & SPI
I2C_SCL = PB_8, /* I2C1 */
I2C_SDA = PB_9,
SPI_MOSI = PA_7,
SPI_MISO = PA_6,
SPI_SCK = PA_5,
SPI_CS = PB_6,
PWM_OUT = PB_3,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in dee4b5e.

@jeromecoutant
Copy link
Contributor

I am sorry, I have updated the README file.
Please rebase on top of master (no merge commit)

@byq77
Copy link
Contributor Author

byq77 commented Jul 21, 2021

Rebased. Should be ok now.

@jeromecoutant
Copy link
Contributor

jeromecoutant commented Jul 21, 2021

Oups, I merged #15 which makes a conflict again...

README.md Outdated
- Green Led on PA10 (LED2) reversed (1=OFF, 0=ON)
- SMD CR2450 battery holder

# STM32F4
Copy link
Contributor

@jeromecoutant jeromecoutant Jul 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment :-)
Could you add STM32F4 after F1, before L0 ?

# Copyright (c) 2020 ARM Limited. All rights reserved.
# SPDX-License-Identifier: Apache-2.0

add_subdirectory(TARGET_CORE2 EXCLUDE_FROM_ALL)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a new line to make GitHub happy ?

@byq77
Copy link
Contributor Author

byq77 commented Jul 21, 2021

Come to surface again ;-P

@jeromecoutant jeromecoutant merged commit b348d2a into ARMmbed:master Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants