Fix compiler warnings about SipHasher and left/right overflowing shifts #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great! Travis doesn't look happy though. |
|
Hmm, I can't reproduce these on my x86_64 linux box. Also the errors are different on the two builds that give errors. What do you think the issue could be? |
|
Are you sing the same flags as travis? Also, could you try to trigger a rebuild by travis? |
|
I am, and the builds that are failing are using no feature flags. I think you can trigger a rebuild as the owner, but I'll just close and reopen the PR and see if that does it. |
|
That didn't work. Looks like quickcheck_macros is actually broken |
|
I sent a quickcheck_macros fix to BurntSushi/quickcheck#153. |
|
You can rebase this onto #85 for passing Travis tests. |
|
There are no longer any overflowing warnings. I'll just submit a new PR for the SipHasher warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.