perf(adamajava): ensure code that calls SAMRecord.getReadGroup() does so sparingly #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… so sparingly The getReadGroup() method in SAMRecord is non-trivial, and there were instances in the code where it was being used carelessly. This PR addresses this by calling the method once and caching the vbalue (where appropririate)
delocalizer
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
getReadGroup() method inSAMRecordis non-trivial, and there were instances in the code where it was being used carelessly. This PR addresses this by calling the method once and caching the value (where appropriate)How Has This Been Tested?
Existing tests pass, and regression tests are green
Are WDL Updates Required?
nope
Checklist: