Skip to content

Conversation

@newellf
Copy link
Contributor

@newellf newellf commented Jul 31, 2024

Fix to remove condition where chrM was automatically changed to chrMT, and so was failing with GRCh38 chrM SNPs

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Updated qbasepileup tests

Are WDL Updates Required?

No

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Fix to remove condition where chrM was automatically changed to chrMT, and so was failing with
GRCh38 chrM SNPs
Copy link
Contributor

@holmeso holmeso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@newellf newellf merged commit 52f0f26 into master Jul 31, 2024
@newellf newellf deleted the qbasepileup_mt branch July 31, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants