Skip to content

Conversation

@newellf
Copy link
Contributor

@newellf newellf commented Oct 7, 2024

To ensure same order in xml output each time, read groups in the BamSummaryReport needed to be sorted before writing to xml

Description

XML produced was not consistent due to read groups not being sorted. Read groups are now sorted before writing to XML

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Added unit tests and ran multiple time on a test BAM file.

Are WDL Updates Required?

WDL test file workflow/test/testSDFTM_GS_xmls.sh need to be updated with new MD5sum for new order

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

To ensure same order in xml output each time, read groups in the BamSummaryReport needed to be
sorted before writing to xml
Copy link
Contributor

@holmeso holmeso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@newellf newellf merged commit a390012 into master Oct 8, 2024
1 check passed
@newellf newellf deleted the qprofiler2_rg branch October 8, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants