Skip to content

Conversation

@newellf
Copy link
Contributor

@newellf newellf commented Nov 26, 2024

For a SplitReadContig, there was a case where the SV was a translocation but a reference check was not performed resulting in the incorrect breakpoint associated with the incorrect reference. Added a reference check

Description

In SplitReadContig, a reference (chromosome) check of the knownSV reference compared with the the proposed split read SV references was added.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Added unit test. Tested qSV with the sample that was failing and also another sample that has been used for testing in the past to make sure the new code didn't have any unintended changes.

Are WDL Updates Required?

No

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

For a SplitReadContig, there was a case where the SV was a translocation but a reference check was
not performed resulting in the incorrect breakpoint associated with the incorrect reference. Added a
reference check
Copy link
Contributor

@holmeso holmeso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@newellf newellf merged commit 6e54e29 into master Nov 26, 2024
1 check passed
@newellf newellf deleted the qsv_bugfix branch November 26, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants