Skip to content

Conversation

@holmeso
Copy link
Contributor

@holmeso holmeso commented Mar 19, 2025

Description

Keep a tally of failed filter read names in the Accumulator object so that the appropriate value can be added to the failed filter field in the vcf for compound snps.

This will allow qannotate to apply the MIUN filter to compound snps.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Additional unit tests have been written, existing tests pass, and code has been run against production BAM files

Are WDL Updates Required?

no

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

holmeso added 2 commits March 3, 2025 11:50
Keep a tally of failed filter read names in the Accumulator object so that the appropriate value can
be added to the failed filter field in the vcf for compound snps
Copy link
Contributor

@newellf newellf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@holmeso holmeso merged commit d3f97ef into master Mar 19, 2025
1 check passed
@holmeso holmeso deleted the qsnp_track_unfiltered_CS branch March 19, 2025 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants