Skip to content

Conversation

Jovonni
Copy link
Contributor

@Jovonni Jovonni commented Jul 25, 2024

addresses #1161

Copy link

cloudflare-workers-and-pages bot commented Jul 25, 2024

Deploying documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: c190d50
Status: ✅  Deploy successful!
Preview URL: https://c1c71e57.documentation-7tp.pages.dev
Branch Preview URL: https://docs-macos-docker-brew-resou.documentation-7tp.pages.dev

View logs

@Jovonni Jovonni requested a review from dckc July 25, 2024 16:23
Copy link

github-actions bot commented Jul 25, 2024

Cloudflare deployment logs are available here

@dckc dckc requested review from 0xpatrickdev and removed request for dckc July 25, 2024 16:51
@dckc
Copy link
Member

dckc commented Jul 25, 2024

I don't do much development on a mac; deferring to @0xpatrickdev

version "1.0.0"
resolved "https://registry.yarnpkg.com/yocto-queue/-/yocto-queue-1.0.0.tgz#7f816433fb2cbc511ec8bf7d263c3b58a1a3c251"
integrity sha512-9bnSc/HEW2uRy67wc+T8UwauLuPJVn28jb+GtJY16iiKWyvmYJRXVT4UamsAEGQfPohgr2q4Tq0sQbQlxTfi1g==
integrity sha512-9bnSc/HEW2uRy67wc+T8UwauLuPJVn28jb+GtJY16iiKWyvmYJRXVT4UamsAEGQfPohgr2q4Tq0sQbQlxTfi1g== No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spurious change?

Copy link
Contributor Author

@Jovonni Jovonni Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very spurious 🫠 added by mistake, and removed it the wrong way.

Copy link
Contributor

@amessbee amessbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jovonni LGTM - let us merge it!

Copy link
Contributor

@0xpatrickdev 0xpatrickdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - we have similar changes in #1160 - but we can close that.

Before merging please these two changes present in 1160 but not here -

  • change the second [installation for Ubuntu] to [installation for Mac] (we have installation for ubuntu 2x)
  • move the group instructions to the Ubuntu <details> - we only need to do this on ubuntu, not mac

Jovonni added a commit that referenced this pull request Aug 6, 2024
Jovonni added a commit that referenced this pull request Aug 6, 2024
@Jovonni
Copy link
Contributor Author

Jovonni commented Aug 7, 2024

moved instructions to ubuntu details:
c190d50

@Jovonni Jovonni marked this pull request as ready for review August 7, 2024 15:05
@Jovonni Jovonni merged commit 6ef2085 into main Aug 7, 2024
@Jovonni Jovonni deleted the docs/macos-docker-brew-resources branch August 7, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants