Skip to content

Conversation

ianton-ru
Copy link

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix remote call of s3Cluster function

Documentation entry for user-facing changes

remote('remote_host', ''s3Cluster(.....)') did not work with error

2024.11.24 09:07:37.307264 [ 11 ] {5548e29a-ab3e-4306-9925-c5d39e47fa9c} <Error> executeQuery: Code: 49. DB::Exception: Distributed task iterator is not initialized: While executing Remote. (LOGICAL_ERROR) (version 24.11.1.1) (from 172.16.1.1:55326) (in query: SELECT * FROM remote('s0_0_1', s3Cluster('cluster_simple', 'http://minio1:9001/root/data/{clickhouse,database}/*', 'minio', '[HIDDEN]', 'CSV', 'name String, value UInt32, polygon Array(Array(Tuple(Float64, Float64)))')) ORDER BY (name, value, polygon) ASC LIMIT 1), Stack trace (when copying this message, always include the lines below):

0. ./contrib/llvm-project/libcxx/include/exception:141: Poco::Exception::Exception(String const&, int) @ 0x0000000014cd1e72
1. /home/iantonspb/ch-build/./src/Common/Exception.cpp:109: DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x000000000ba7cad9
2. DB::Exception::Exception(PreformattedMessage&&, int) @ 0x00000000069abf0c
3. DB::Exception::Exception<>(int, FormatStringHelperImpl<>) @ 0x00000000069b5e8b
4. /home/iantonspb/ch-build/./src/QueryPipeline/RemoteQueryExecutor.cpp:715: DB::RemoteQueryExecutor::processReadTaskRequest() @ 0x000000000fecbf12
5. /home/iantonspb/ch-build/./src/QueryPipeline/RemoteQueryExecutor.cpp:614: DB::RemoteQueryExecutor::processPacket(DB::Packet) @ 0x000000000feca25a
6. /home/iantonspb/ch-build/./src/QueryPipeline/RemoteQueryExecutor.cpp:553: DB::RemoteQueryExecutor::readAsync() @ 0x000000000fecb60c
7. /home/iantonspb/ch-build/./src/Processors/Sources/RemoteSource.cpp:182: DB::RemoteSource::tryGenerate() @ 0x000000001295b590
8. /home/iantonspb/ch-build/./src/Processors/ISource.cpp:108: DB::ISource::work() @ 0x0000000012648b45
9. /home/iantonspb/ch-build/./src/Processors/Executors/ExecutionThreadContext.cpp:49: DB::ExecutionThreadContext::executeTask() @ 0x000000001265fc00
10. /home/iantonspb/ch-build/./src/Processors/Executors/PipelineExecutor.cpp:289: DB::PipelineExecutor::executeStepImpl(unsigned long, std::atomic<bool>*) @ 0x0000000012655c3f
11. /home/iantonspb/ch-build/./src/Processors/Executors/PipelineExecutor.cpp:255: DB::PipelineExecutor::executeImpl(unsigned long, bool) @ 0x000000001265541d
12. /home/iantonspb/ch-build/./src/Processors/Executors/PipelineExecutor.cpp:126: DB::PipelineExecutor::execute(unsigned long, bool) @ 0x0000000012655207
13. /home/iantonspb/ch-build/./src/Processors/Executors/PullingAsyncPipelineExecutor.cpp:83: void std::__function::__policy_invoker<void ()>::__call_impl<std::__function::__default_alloc_func<ThreadFromGlobalPoolImpl<true, true>::ThreadFromGlobalPoolImpl<DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0>(DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0&&)::'lambda'(), void ()>>(std::__function::__policy_storage const*) @ 0x0000000012662d8c
14. ./contrib/llvm-project/libcxx/include/__functional/function.h:848: ? @ 0x000000000bb49da3
15. ./contrib/llvm-project/libcxx/include/__functional/invoke.h:359: ? @ 0x000000000bb4f07b
16. ? @ 0x00007f08de1c4ac3
17. ? @ 0x00007f08de256850

The reason is this:
https://github.com/ClickHouse/ClickHouse/blob/master/src/TableFunctions/TableFunctionObjectStorageCluster.cpp#L34
s3Cluster function has two stages, and stage is choose depends of query_kind - INITIAL_QUERY for first stage and SECONDARY_QUERY for second stage. When s3Cluster called from remote function, both stages were with SECONDARY_QUERY.

Now requests from remote function use INITIAL_QUERY.

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/


Modify your CI run:

NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step

Include tests (required builds will be added automatically):

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Unit tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with Analyzer
  • Add your option here

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • Add your option here

Extra options:

  • do not test (only style check)
  • disable merge-commit (no merge from master before tests)
  • disable CI cache (job reuse)

Only specified batches in multi-batch jobs:

  • 1
  • 2
  • 3
  • 4

robot-clickhouse and others added 30 commits October 1, 2024 19:10
Backport ClickHouse#70147 to 24.8: Fix Dynamic type creation of JSON subcolumn
Backport ClickHouse#70123 to 24.8: Check for Nullable(Nothing) type during ALTER TABLE MODIFY COLUMN/QUERY
Backport ClickHouse#70148 to 24.8: Fix bcrypt password being displayed in system.query_log
Backport ClickHouse#70144 to 24.8: Fix possible hung in ALTER COLUMN with Dynamic type
Backport ClickHouse#70127 to 24.8: Fix wrong result with skipping index
Backport ClickHouse#70159 to 24.8: Update test_storage_s3_queue/test.py
Backport ClickHouse#70218 to 24.8: Respect setting allow_simdjson in JSON type parser
Backport ClickHouse#70294 to 24.8: CI: Remove await feature from release branches
…port/24.8/70146

Revert "Backport ClickHouse#70146 to 24.8: Upgrade integration-runner image"
Backport ClickHouse#70207 to 24.8: Fix multiple issues with arrayMin and arrayMax
Backport ClickHouse#67664 to 24.8: Fix error on generated columns in MaterializedPostgreSQL
Backport ClickHouse#70338 to 24.8: Fix crash when using WITH FILL incorrectly
MyroTk and others added 26 commits December 9, 2024 06:33
…_tests

24.8 TMP fix: Disabled getting AZURE_CONNECTION_STRING from SSM
…_tests

24.8 fix stateless and stateful tests
24.8 Fix Builds Report and FinishCheck
@altinity-robot
Copy link
Collaborator

altinity-robot commented Dec 16, 2024

This is an automated comment for commit 6ee5056 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Sign aarch64There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS❌ error
Sign releaseThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS❌ error
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ error
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Ready for releaseThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success

@Enmk Enmk changed the base branch from project-antalya to project-antalya-24.12.2 January 29, 2025 14:22
@ianton-ru ianton-ru closed this Jan 30, 2025
@ianton-ru
Copy link
Author

Double of #583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.