Skip to content

Issue #381 Spender aggregates - structs and setup #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 56 commits into from
Apr 22, 2021
Merged

Issue #381 Spender aggregates - structs and setup #388

merged 56 commits into from
Apr 22, 2021

Conversation

elpiel
Copy link
Member

@elpiel elpiel commented Mar 23, 2021 •
edited
Loading

Partially resolves #381

  • Setup module primitives::spender
    • Spendable with postgres impl From<Row>
    • Dummy Aggregate struct
  • Setup sentry::spender
    • Dummy Aggregator struct (no implementation yet)
    • fee:calculate_fees - new fee calculation
  • Setup module sentry::db::spendable
    • insert_spendable
    • fetch_spendable
  • sentry::db::postgres_pool - Test pool & migration setup for testing DB
  • sentry migrations - Update & fix migrations
  • validator_worker - remove Fee calculation

elpiel and others added 30 commits March 12, 2021 09:39
@elpiel
primitives - remove unused ValidatorError
6a9ca1a
@elpiel
primitives - Channel v5 & Campaing + move structs
aaabc5a
@elpiel
primitives - ToHex & address::Address
a4b2ebb
@elpiel
primitives - Address - improvements
e5ed959
@elpiel
primitives - channel v5 - use Address
fc5f7e9
@elpiel
primitives - campaign - spec Validators and matching
4a803ab
@elpiel
rustfmt
fa4f084
@elpiel
primitives - campaign - merge spec and change fields
defa9ab
@elpiel
primitives - Cargo - update deps and remove duplicates
9ae51cc
@elpiel
primitives - channel_v5 - Nonce & Channel fn id()
98790b5
@elpiel
primitives - ValidatorId to_address & as_bytes
7ea437b
@elpiel
primtivies campaign::Active - fix to name
564ba9c
@elpiel
Merge pull request #383 from AdExNetwork/issue-382-channel-and-campaign
9c76970 
AdEx v5: Issue #382 Channel and Campaign
@elpiel
primitives - UnifiedNum
3f8ec05
@elpiel
pirmitives - BigNum - impl num::pow::Pow
be47342
@elpiel
primitives - UnifiedNum - impl num::pow::Pow & to_preicison()
080b517
@elpiel
primitives - UnifiedNum - test for Zero & One
9815a24
@elpiel
primitives - BigNum - impl Display instead of ToString
055307c
@elpiel
primitives - ValidatorMessage with a Generic
0804b77
@elpiel
primitives - impl FromStr for ValidatorId
a086b9c
@elpiel
primitives - sentry - MessageResponse test
6f149b2
@elpiel
primivies - ValidatorId change errors to address::Error
eb006a3
@elpiel
primitives - UnifiedNum - use u64 as internal value
310ea23
@elpiel
primitives - UnifiedNum - Update doc
a38e0f2
@elpiel
primitives - UnifiedNum - fix test comment
5903527
@elpiel
Merge pull request #386 from AdExNetwork/issue-384-unified-precision
7621a77 
AdEx v5: Issue #384 Unified precision - primitives::UnifiedNum
@elpiel
Merge pull request #387 from AdExNetwork/validator-messages-improvements
f345f6a 
Validator Messages improvements
@elpiel
add todos for #381
b6ec00c
@elpiel
todo to change BalancesMap's ValidatorId to Address
b5c4e73
@elpiel
primitives - UnifiedNum - (De)Serialize & docs clarification
c152159
@elpiel elpiel changed the base branch from aip-61-adex-v5 to aip-61-all-around-generic-changes April 5, 2021 10:31
@elpiel elpiel changed the base branch from aip-61-all-around-generic-changes to aip-61-adex-v5 April 5, 2021 13:05
elpiel added 10 commits April 9, 2021 16:07
@elpiel elpiel marked this pull request as ready for review April 14, 2021 13:08
@elpiel elpiel mentioned this pull request Apr 19, 2021
Closed
21 tasks
@elpiel elpiel requested review from samparsky and simzzz April 19, 2021 11:44
@elpiel elpiel merged commit ce122e1 into aip-61-adex-v5 Apr 22, 2021
@elpiel elpiel deleted the issue-381-spender-aggregates branch August 12, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simzzz simzzz Awaiting requested review from simzzz

1 more reviewer

@samparsky samparsky samparsky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

primitives Changes regarding the `primitives` crate

Projects

None yet

Milestone

sentry-v0.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@elpiel @samparsky