Skip to content

Issue 382 campaign routes #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 64 commits into from
Aug 10, 2021
Merged

Issue 382 campaign routes #411

merged 64 commits into from
Aug 10, 2021

Conversation

@elpiel
Copy link
Member

@elpiel elpiel commented Jun 13, 2021 •
edited
Loading

Part of #382

  • Sentry - Middleware - Campaign Load
  • Create/Modify Campaign
  • Insert new Events

@elpiel elpiel marked this pull request as draft June 13, 2021 08:25
simzzz and others added 15 commits June 14, 2021 16:10
@simzzz
added regex for campaign update route
1b8cd75
@simzzz
Merge branch 'issue-381-accounting-db' into v5-modify-submit-campaigns
efb30f9
@elpiel
sentry - route - campaign - insert events
be47fe2 
- Regex for matching Campaign Close & Campaign insert events
@elpiel
primitives - sentry - remove Events:
00abea5 
- removed Update targeting, Close & Pay events
- sentry - comment out channel::Insert_events
- sentry - access - remove unnecessary checks & use Campaign instead of Channel
@simzzz
Accounting messages + First integration tests
57116cc
@simzzz
fixed some unwraps
f4e0949
@simzzz
more fixes
825d6cb
@elpiel
sentry - routes - channel - remove insert_events
5f0e1c9
@simzzz
Merge branch 'issue-382-campaign-routes' into v5-modify-submit-campaigns
5fd05db
@elpiel
sentry - clean up Events code in Channel & access
115b7b0
@elpiel
Merge branch 'aip61-targeting-rules-use-unified-num' into issue-382-c…
67a9462 
…ampaign-insert-events
@elpiel
Merge branch 'aip-61-adex-v5' into issue-382-campaign-routes
2d73644
@elpiel
Merge branch 'issue-382-campaign-routes' into issue-382-campaign-inse…
bcf3d9a 
…rt-events
@simzzz
fixed remaining issues in PR
067b3af
@simzzz
Included MGET for getting multiple remainings at once
9fd4f4a
elpiel and others added 24 commits July 12, 2021 15:40
@elpiel
Merge branch 'aip-61-adex-v5' into issue-382-campaign-routes
b81584b
@simzzz
Merge branch 'issue-382-campaign-routes' into v5-modify-submit-campaigns
0082a35
@elpiel
sentry - routes - modify campaign
8fcef13
@elpiel
sentry - db - campaign - fix doc comment
b664dd1
@elpiel
Merge branch 'issue-382-campaign-routes' into issue-382-campaign-inse…
a2cabe2 
…rt-events
@elpiel
sentry - mod test_util - setup_dummy_app helper fn
10deba9
@elpiel
sentry - db - campaign - CampaignRemaining redis struct
88c3243
@elpiel
primitives - sentry - impl From<Campaign> for CreateCampaign
3ca6ab5
@elpiel
primitives - validator - From<Address> for ValidatorID
11dc715
@elpiel
primitives - sentry - accounting - Balances - add spender/earner
07d9c74
@elpiel
sentry - Applicaiton - add CampaignRemaining to app
d80e109
@elpiel
sentry - db - CampaignRemaining - MGET guard against empty vec of cam…
e1a245e 
…paigns
@elpiel
sentry - routes - campaign create/modify - more checks & tests
9a94c5f
@elpiel
fix PR comments
2752dea
@elpiel
sentry - db - make pub insert_accounting
5177217
@elpiel
sentry - routes - campaign - get_delta_budget - fix logic & naming
75a5a5f
@elpiel
Merge pull request #418 from AdExNetwork/redis-and-tests
19ccd17 
Issue #415 Create/Modify Campaigns - Redis and tests
@elpiel
Merge pull request #408 from AdExNetwork/v5-modify-submit-campaigns
c6c63bc 
V5: Authenticated POST route to modify/submit campaigns
@elpiel
Merge branch 'issue-382-campaign-routes' into issue-382-campaign-inse…
fa39cb1 
…rt-events
@elpiel
Fix merge issues & run rustfmt
70376b3
@elpiel
fix clippy warnings
1fca9ec
@elpiel
rustfmt
05ac2b0
@elpiel
sentry - routes - camiang insert events - use CampaignRemaining
598ab52
@elpiel
Merge pull request #413 from AdExNetwork/issue-382-campaign-insert-ev…
30b375d 
…ents

Issue 382 campaign insert events
@elpiel elpiel marked this pull request as ready for review August 10, 2021 07:11
@elpiel elpiel merged commit c441b99 into aip-61-adex-v5 Aug 10, 2021
@elpiel elpiel deleted the issue-382-campaign-routes branch August 12, 2021 15:44
@elpiel elpiel restored the issue-382-campaign-routes branch August 12, 2021 15:44
@elpiel elpiel deleted the issue-382-campaign-routes branch September 28, 2021 07:55
@elpiel elpiel linked an issue Oct 4, 2021 that may be closed by this pull request
AIP #61 v5: Sentry POST route for inserting/modifying campaign #409
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AIP #61 v5: Sentry POST route for inserting/modifying campaign

2 participants

@elpiel @simzzz