GET /v5/campaign/list #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

elpiel merged 14 commits into aip-61-adex-v5 from issue-429-campaign-list

Sep 30, 2021

Contributor

simzzz commented Sep 16, 2021 •

edited

Loading

resolves #429


          initial implementation

6644bb5

simzzz changed the base branch from master to aip-61-adex-v5

September 16, 2021 11:36

simzzz added 2 commits

September 16, 2021 15:33


          added authenticated validator to be used if none is provided, fixed a…

3e1b95f

… few problems with the logic


          added todo comment

e4980b3

simzzz mentioned this pull request

AIP #61 v5: Channel and Campaign #382

Closed

21 tasks

simzzz requested a review from elpiel

September 17, 2021 11:26

elpiel requested changes

View reviewed changes

Member

elpiel left a comment •

edited by simzzz

Loading

Write tests to make sure that listing Campaigns & the total count work correctly. Generate multiple Campaigns and use a lower limit for the page results for easier impl

primitives/src/sentry.rs Show resolved Hide resolved

sentry/src/db/campaign.rs Outdated Show resolved Hide resolved

sentry/src/db/campaign.rs Outdated Show resolved Hide resolved

sentry/src/db/campaign.rs Outdated Show resolved Hide resolved

sentry/src/db/campaign.rs Outdated Show resolved Hide resolved

validator_worker/src/sentry_interface.rs Outdated Show resolved Hide resolved

simzzz added 4 commits

September 20, 2021 20:31


          requested changes excluding tests

7fe1f88


          Merge branch 'aip-61-adex-v5' into issue-429-campaign-list

ebf3dc7


          fixes + tests

361d538


          changes to tests, changes to campaign query functions

eca67f6

elpiel reviewed

View reviewed changes

sentry/src/db/campaign.rs Outdated Show resolved Hide resolved

elpiel reviewed

View reviewed changes

sentry/src/db/campaign.rs Outdated Show resolved Hide resolved


          fixed total count query and uncommented tests

ba2c451

elpiel reviewed

View reviewed changes

primitives/src/util/tests/prep_db.rs Outdated Show resolved Hide resolved


          changed campaign list test function

1d2b8ee

elpiel requested changes

View reviewed changes

sentry/src/db/campaign.rs Outdated Show resolved Hide resolved

elpiel reviewed

View reviewed changes

sentry/src/lib.rs Outdated Show resolved Hide resolved

elpiel reviewed

View reviewed changes

sentry/src/routes/campaign.rs Outdated Show resolved Hide resolved

simzzz added 4 commits

September 27, 2021 11:39


          moved path handling to campaign router, changes to tests

5764e60


          changes to tests

6f6668c


          Merge branch 'aip-61-adex-v5' into issue-429-campaign-list

fc70836


          merge + fmt + clippy

f9f726b

elpiel requested changes

View reviewed changes

Member

elpiel left a comment •

edited by simzzz

Loading

Fix the Comment on the test
Fix the query.validator & Auth case.

sentry/src/routes/campaign.rs Outdated Show resolved Hide resolved


          added campaign_find_limt to config, fixed documentation and match sta…

7b8fd38

…tement

elpiel approved these changes

View reviewed changes

elpiel merged commit 692bf08 into aip-61-adex-v5

elpiel deleted the issue-429-campaign-list branch

October 4, 2021 06:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet